remoting_me2me_host: Heap-allocate a 4K buffer.

remoting_me2me_host: Heap-allocate a 4K buffer.

Objects of this size should not be stack-allocated.

Committed: https://crrev.com/c57aaa0ac051292007dde421e25802059d98b674
Cr-Commit-Position: refs/heads/master@{#337959}

[Matt Giuca, 2015-07-08 03:07:02]

mgiuca@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Matt Giuca, 2015-07-08 03:07:02]

Suggested by cpu@ in
https://codereview.chromium.org/1220133003/diff/100001/remoting/host/remoting...

[Wez, 2015-07-08 17:17:04]

wez@chromium.org changed reviewers:
+ wez@chromium.org

[Wez, 2015-07-08 17:17:04]

I don't see any issues w/ this CL, but I also don't see any benefit, since this
is a one-off allocation while reading the configuration file in.

cpu@, is this just a question of consistency with other code where the heap vs
stack choice would make a difference?

[Matt Giuca, 2015-07-08 23:58:07]

From cpu@ on the other CL:
"stack allocations this big are bad news. I basically forces a page fault and
increases the stack watermark forever."

That makes sense to me (though I'm not sure what the consequences of pushing up
the stack watermark are). Stack frames should be kept small, even in one-off
code like this.

[Wez, 2015-07-09 01:00:04]

On 2015/07/08 23:58:07, Matt Giuca wrote:
> From cpu@ on the other CL:
> "stack allocations this big are bad news. I basically forces a page fault and
> increases the stack watermark forever."
> 
> That makes sense to me (though I'm not sure what the consequences of pushing
up
> the stack watermark are). Stack frames should be kept small, even in one-off
> code like this.

OK, fair enough. :)

LGTM!

[Matt Giuca, 2015-07-09 01:00:26]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-07-09 01:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218073018/1

[commit-bot: I haz the power, 2015-07-09 01:10:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-09 01:11:16]

Patchset 1 (id:??) landed as
https://crrev.com/c57aaa0ac051292007dde421e25802059d98b674
Cr-Commit-Position: refs/heads/master@{#337959}