Fixed all unused-variable Clang warnings on Windows.

remoting/host/remoting_me2me_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements a standalone host process for Me2Me.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 98 matching lines @@
 
 using remoting::protocol::PairingRegistry;
 using remoting::protocol::NetworkSettings;
 
 #if defined(USE_REMOTING_MACOSX_INTERNAL)
 #include "remoting/tools/internal/internal_mac-inl.h"
 #endif
 
 namespace {
 
+#if !defined(REMOTING_MULTI_PROCESS)
 // This is used for tagging system event logs.
 const char kApplicationName[] = "chromoting";
 
+// Value used for --host-config option to indicate that the path must be read
+// from stdin.
+const char kStdinConfigPath[] = "-";
+#endif  // !defined(REMOTING_MULTI_PROCESS)
+
 #if defined(OS_LINUX)
 // The command line switch used to pass name of the pipe to capture audio on
 // linux.
 const char kAudioPipeSwitchName[] = "audio-pipe-name";
 
 // The command line switch used to pass name of the unix domain socket used to
 // listen for gnubby requests.
 const char kAuthSocknameSwitchName[] = "ssh-auth-sockname";
 #endif  // defined(OS_LINUX)
 
 // The command line switch used by the parent to request the host to signal it
 // when it is successfully started.
 const char kSignalParentSwitchName[] = "signal-parent";
 
 // Command line switch used to enable VP9 encoding.
 const char kEnableVp9SwitchName[] = "enable-vp9";
 
 // Command line switch used to enable and configure the frame-recorder.
 const char kFrameRecorderBufferKbName[] = "frame-recorder-buffer-kb";
 
-// Value used for --host-config option to indicate that the path must be read
-// from stdin.
-const char kStdinConfigPath[] = "-";
-
 const char kWindowIdSwitchName[] = "window-id";
 
 // Maximum time to wait for clean shutdown to occur, before forcing termination
 // of the process.
 const int kShutdownTimeoutSeconds = 15;
 
 // Maximum time to wait for reporting host-offline-reason to the service,
 // before continuing normal process shutdown.
 const int kHostOfflineReasonTimeoutSeconds = 10;
 
@@ skipping 323 matching lines @@
                                   IPC::Channel::MODE_CLIENT,
                                   this,
                                   context_->network_task_runner().get());
   }
 
   if (cmd_line->HasSwitch(kHostConfigSwitchName)) {
     host_config_path_ = cmd_line->GetSwitchValuePath(kHostConfigSwitchName);
 
     // Read config from stdin if necessary.
     if (host_config_path_ == base::FilePath(kStdinConfigPath)) {
       char buf[4096];

[cpu_(ooo_6.6-7.5), 2015/07/07 17:39:24]

stack allocations this big are bad news. I basically forces a page fault and
increases the stack watermark forever.

All this code around here looks pretty weird, I wonder if REMOTING_MULTI_PROCESS
is on or off ...

[Matt Giuca, 2015/07/08 02:51:28]

According to remoting/remoting_options.gypi, it is 1 on Windows, 0 elsewhere.
(So on Windows we had an unused variable that we were using on the other
platforms.)

Surely there is an abstraction of fread in base somewhere? (All I could find is
base::ReadFileToString, which takes a path and doesn't work for stdin.)

At least we can heap-allocate this. I'll do it in a follow-up.

       size_t len;
       while ((len = fread(buf, 1, sizeof(buf), stdin)) > 0) {
         host_config_.append(buf, len);
       }
     }
   } else {
     base::FilePath default_config_dir = remoting::GetConfigDir();
     host_config_path_ = default_config_dir.Append(kDefaultHostConfigFile);
   }
 
@@ skipping 1144 matching lines @@
       base::TimeDelta::FromSeconds(kShutdownTimeoutSeconds));
   new HostProcess(context.Pass(), &exit_code, &shutdown_watchdog);
 
   // Run the main (also UI) message loop until the host no longer needs it.
   message_loop.Run();
 
   return exit_code;
 }
 
 }  // namespace remoting