tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/smoke.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

index 9047ae6e4bf0fe1865fae0c008105ebf80481256..5c47806c12d0867b02132eea37d8b796b23fc410 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

@@ -5,7 +5,7 @@ import logging

from telemetry.core import exceptions

from telemetry.page import page as page_module

-from telemetry.page import page_set as page_set_module

+from telemetry import story

class SafebrowsingPage(page_module.Page):

@@ -29,12 +29,12 @@ class SafebrowsingPage(page_module.Page):

raise e

-class SafebrowsingPageSet(page_set_module.PageSet):

+class SafebrowsingStorySet(story.StorySet):

""" Chrome proxy test sites """

def __init__(self, expect_timeout=False):

- super(SafebrowsingPageSet, self).__init__()

+ super(SafebrowsingStorySet, self).__init__()

- self.AddUserStory(

+ self.AddStory(

SafebrowsingPage('http://www.ianfette.org/', self, expect_timeout))