tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py

index dc7402931a16a58011ba48f046d9626b2d700c1d..8c9befb5cf51fee0aa84bbb1fe2d3a16945b4674 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/reenable_after_bypass.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

from telemetry.page import page as page_module

-from telemetry.page import page_set as page_set_module

+from telemetry import story

class ReenableAfterBypassPage(page_module.Page):

@@ -26,15 +26,15 @@ class ReenableAfterBypassPage(page_module.Page):

self.bypass_seconds_max = bypass_seconds_max

-class ReenableAfterBypassPageSet(page_set_module.PageSet):

+class ReenableAfterBypassStorySet(story.StorySet):

""" Chrome proxy test sites """

def __init__(self):

- super(ReenableAfterBypassPageSet, self).__init__()

+ super(ReenableAfterBypassStorySet, self).__init__()

# Test page for "Chrome-Proxy: block=0". Loading this page should cause all

# data reduction proxies to be bypassed for one to five minutes.

- self.AddUserStory(ReenableAfterBypassPage(

+ self.AddStory(ReenableAfterBypassPage(

url="http://check.googlezip.net/block",

page_set=self,

bypass_seconds_min=60,