[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

CLOSED: superseded by https://codereview.chromium.org/1465383003/

[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

This CL:
 - removes apache from ChromeInstrumentationTestRunner
 - converts TabsTest to use EmbeddedTestServer
 - fixes a few miscellaneous gn issues

BUG=488195

[jbudorick, 2015-07-15 21:22:36]

jbudorick@chromium.org changed reviewers:
+ aurimas@chromium.org, cjhopman@chromium.org, tedchoc@chromium.org,
yfriedman@chromium.org

[jbudorick, 2015-07-15 21:22:37]

TabsTest is an example -- I didn't want to switch over any more tests before
getting some feedback. Eventually, though, I'd like to replace all uses of
TestHttpServerClient (read: the host-side HTTP server currently used by the
instrumentation tests) in a similar manner.

ptal:
  yfriedman + tedchoc: base/, chrome/
  cjhopman: gyp + gn
  aurimas: fyi

[cjhopman, 2015-07-16 00:25:36]

I don't think we can package native code into instrumentation test apks. There's
a bug where we had more in-depth discussion of why we shouldn't try to do it,
I'll see if I can find it.

[jbudorick, 2015-07-16 00:35:06]

On 2015/07/16 at 00:25:36, cjhopman wrote:
> I don't think we can package native code into instrumentation test apks.
There's a bug where we had more in-depth discussion of why we shouldn't try to
do it, I'll see if I can find it.

What do you mean, that it's not possible or that we shouldn't?

With this CL, TabsTest runs with an http server running from a native library in
the instrumentation test apk.

[jbudorick, 2015-07-16 00:38:29]

On 2015/07/16 at 00:35:06, jbudorick wrote:
> On 2015/07/16 at 00:25:36, cjhopman wrote:
> > I don't think we can package native code into instrumentation test apks.
There's a bug where we had more in-depth discussion of why we shouldn't try to
do it, I'll see if I can find it.
> 
> What do you mean, that it's not possible or that we shouldn't?

Derp, got hung up on the first sentence. I'll be interested to see that bug if
you find it.

> 
> With this CL, TabsTest runs with an http server running from a native library
in the instrumentation test apk.

[cjhopman, 2015-07-16 18:29:57]

On 2015/07/16 00:38:29, jbudorick wrote:
> On 2015/07/16 at 00:35:06, jbudorick wrote:
> > On 2015/07/16 at 00:25:36, cjhopman wrote:
> > > I don't think we can package native code into instrumentation test apks.
> There's a bug where we had more in-depth discussion of why we shouldn't try to
> do it, I'll see if I can find it.
> > 
> > What do you mean, that it's not possible or that we shouldn't?
> 
> Derp, got hung up on the first sentence. I'll be interested to see that bug if
> you find it.
> 
> > 
> > With this CL, TabsTest runs with an http server running from a native
library
> in the instrumentation test apk.

From email:

I think the main problem is that in a component build, the test and the app will
share a bunch of libraries (and thus all the statics there are shared), but in a
non-component build those things aren't shared. I don't think it's feasible to
actually have that work and have people understand the limitations when writing
code in that context.

There are two approaches we've used in the past when we needed native code for
tests:

1. Package everything into a single apk. This is done for all unit tests, but it
is also possible to use this approach for instrumentation tests (I believe that
mojo does that).
2. Put the native code in a separate "support" apk and expose it to the tests by
a service or some such.

I was thinking about this a bit more last night and there's actually a third
approach that we could take. It's a bit more complicated than 2, and I don't
know if it's really worth it:

3. Put the native code into the instrumentation apk, but only load it in a
service in a separate process. We would have to ensure then that in the main
process, the libraries that are loaded are from the tested apk and in the other
process that they are from the test apk.

[sgurun-gerrit only, 2015-10-21 01:45:31]

Description was changed from

==========
[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

This CL:
 - removes apache from ChromeInstrumentationTestRunner
 - converts TabsTest to use EmbeddedTestServer
 - fixes a few miscellaneous gn issues

BUG=488195
==========

to

==========
[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

This CL:
 - removes apache from ChromeInstrumentationTestRunner
 - converts TabsTest to use EmbeddedTestServer
 - fixes a few miscellaneous gn issues

BUG=488195
==========

[aurimas (slooooooooow), 2015-11-13 22:31:31]

aurimas@chromium.org changed reviewers:
- aurimas@chromium.org

[jbudorick, 2015-11-24 02:44:48]

Description was changed from

==========
[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

This CL:
 - removes apache from ChromeInstrumentationTestRunner
 - converts TabsTest to use EmbeddedTestServer
 - fixes a few miscellaneous gn issues

BUG=488195
==========

to

==========
CLOSED: superseded by https://codereview.chromium.org/1465383003/

[Android] Begin switching from lighttpd + apache to EmbeddedTestServer.

This CL:
 - removes apache from ChromeInstrumentationTestRunner
 - converts TabsTest to use EmbeddedTestServer
 - fixes a few miscellaneous gn issues

BUG=488195
==========