Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: src/type-feedback-vector.h

Issue 1217943004: Vector ICs: Introduce an InstanceType for the type feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improved printer. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/type-feedback-vector.h
diff --git a/src/type-feedback-vector.h b/src/type-feedback-vector.h
index ee2d20030b4dff5ee07dffef506401be8606ddc8..b4a2fa78c540cb3d0616879e45e334e33b26dbcd 100644
--- a/src/type-feedback-vector.h
+++ b/src/type-feedback-vector.h
@@ -9,7 +9,7 @@
#include "src/checks.h"
#include "src/elements-kind.h"
-#include "src/heap/heap.h"
+// #include "src/heap/heap.h"
Benedikt Meurer 2015/06/30 09:43:43 Nit: Nuke unused includes. No need to leave them a
mvstanton 2015/06/30 15:00:46 Done.
#include "src/isolate.h"
#include "src/objects.h"
#include "src/zone-containers.h"
@@ -186,12 +186,20 @@ class TypeFeedbackVector : public FixedArray {
Code::Kind GetKind(FeedbackVectorICSlot slot) const;
template <typename Spec>
- static Handle<TypeFeedbackVector> Allocate(Isolate* isolate,
- const Spec* spec);
+ static int SizeFor(const Spec* spec);
+
+ template <typename Spec>
+ void Init(Isolate* isolate, const Spec* spec);
static Handle<TypeFeedbackVector> Copy(Isolate* isolate,
Handle<TypeFeedbackVector> vector);
+ DECLARE_PRINTER(TypeFeedbackVector)
+
+ // TODO(Mvstanton): why doesn't this macro work?
+ // DECLARE_VERIFIER(TypeFeedbackVector)
+ void TypeFeedbackVectorVerify();
+
// Clears the vector slots and the vector ic slots.
void ClearSlots(SharedFunctionInfo* shared) { ClearSlotsImpl(shared, true); }
void ClearSlotsAtGCTime(SharedFunctionInfo* shared) {

Powered by Google App Engine
This is Rietveld 408576698