Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1217943003: Use base/threading interface instead of calling Win32 API directly (Closed)

Created:
5 years, 5 months ago by Takashi Toyoshima
Modified:
5 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, scherkus (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base/threading interface instead of calling Win32 API directly VideoRendererImpl calls Win32 API to change a thread priority, but it should be changed via base/threading interface to make code portable. BUG=468793 Committed: https://crrev.com/4f7e20480c87ce02fc8ac93f9af5fc1ea1f7c24e Cr-Commit-Position: refs/heads/master@{#336735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Takashi Toyoshima
Hi scherkus, I find this in the midst of removing id() and platform_handle() interfaces from ...
5 years, 5 months ago (2015-06-30 03:50:51 UTC) #2
Takashi Toyoshima
oops, status shows "not reviewing" I'll find another reviewer.
5 years, 5 months ago (2015-06-30 03:51:34 UTC) #3
Takashi Toyoshima
DaleCurtis, can you take a look?
5 years, 5 months ago (2015-06-30 03:52:27 UTC) #5
DaleCurtis
lgtm
5 years, 5 months ago (2015-06-30 05:39:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217943003/1
5 years, 5 months ago (2015-06-30 05:51:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 07:08:06 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 07:09:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f7e20480c87ce02fc8ac93f9af5fc1ea1f7c24e
Cr-Commit-Position: refs/heads/master@{#336735}

Powered by Google App Engine
This is Rietveld 408576698