Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217933002: Rename RenderCanvas to PaintingCanvas to avoid confusion with other classes that inherit from Rende… (Closed)

Created:
5 years, 5 months ago by iansf
Modified:
5 years, 5 months ago
Reviewers:
abarth, Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename RenderCanvas to PaintingCanvas to avoid confusion with other classes that inherit from RenderObject. R=ianh@google.com, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/121632952b5dcbb1c6c4cb39d3605e65c96e8025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -525 lines) Patch
M sky/sdk/example/game/lib/game_demo_world.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/game/lib/node.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M sky/sdk/example/game/lib/node_with_size.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/example/game/lib/sprite.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/game/lib/sprite_box.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/rendering/sector_layout.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sky/sdk/example/rendering/touch_demo.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/README.md View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/block.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/rendering/box.dart View 15 chunks +15 lines, -15 lines 0 comments Download
M sky/sdk/lib/rendering/flex.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/rendering/object.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/paragraph.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/rendering/stack.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/tabs.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/examples/sector-expected.txt View 1 chunk +278 lines, -278 lines 0 comments Download
M sky/tests/examples/stocks-expected.txt View 3 chunks +35 lines, -35 lines 0 comments Download
M sky/tests/examples/styled_text-expected.txt View 1 chunk +32 lines, -32 lines 0 comments Download
M sky/tests/examples/tabs-expected.txt View 1 chunk +27 lines, -27 lines 0 comments Download
M sky/tests/raw/box_layout-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/raw/padding_deflate-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tests/raw/render_box-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/raw/render_flex-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M sky/tests/raw/sector_layout-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M sky/tests/resources/display_list.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 1 chunk +17 lines, -17 lines 0 comments Download
M sky/tests/widgets/dialog-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M sky/tests/widgets/syncs1-expected.txt View 1 chunk +43 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hixie
lgtm RSLGTM
5 years, 5 months ago (2015-06-29 21:18:17 UTC) #1
iansf
5 years, 5 months ago (2015-06-29 21:19:36 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
121632952b5dcbb1c6c4cb39d3605e65c96e8025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698