Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1217893013: Don't preload rarely seen large images (Closed)

Created:
5 years, 5 months ago by zbowling_chromium
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't preload rarely seen large images The layer cardback image uses 180k memory decompressed but only seen on merged tab switcher on non-low memory devices. Also tweak the preloading logic to not preload tablet only resources on phones. BUG=503437 Committed: https://crrev.com/5c12ff9635888315abbba2519501a621634932f0 Cr-Commit-Position: refs/heads/master@{#337557}

Patch Set 1 #

Total comments: 2

Patch Set 2 : spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/resources/StaticResourcePreloads.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
zbowling_chromium
mariakhomenko@chromium.org: Please review changes in dtrainor@chromium.org: Please review changes in
5 years, 5 months ago (2015-07-01 20:19:09 UTC) #2
Maria
lgtm Please wait for David to take a look before submitting. David, how would you ...
5 years, 5 months ago (2015-07-01 21:46:24 UTC) #4
zbowling_chromium
https://codereview.chromium.org/1217893013/diff/1/chrome/browser/android/compositor/layer/tab_layer.cc File chrome/browser/android/compositor/layer/tab_layer.cc (right): https://codereview.chromium.org/1217893013/diff/1/chrome/browser/android/compositor/layer/tab_layer.cc#newcode220 chrome/browser/android/compositor/layer/tab_layer.cc:220: resource_manager_->GetResource(ui::ANDROID_RESOURCE_TYPE_STATIC, On 2015/07/01 21:46:24, Maria wrote: > indent + ...
5 years, 5 months ago (2015-07-01 22:21:30 UTC) #5
David Trainor- moved to gerrit
lgtm! Re removal: I don't really feel strongly either way. I think we could remove ...
5 years, 5 months ago (2015-07-06 20:48:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217893013/20001
5 years, 5 months ago (2015-07-07 03:06:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 03:54:17 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 03:55:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c12ff9635888315abbba2519501a621634932f0
Cr-Commit-Position: refs/heads/master@{#337557}

Powered by Google App Engine
This is Rietveld 408576698