Disable domain reliability on low-mem Android

Disable domain reliability on low-mem Android

Domain reliability uses 400k+ of memory on the heap. Disabling it until it's
refactored when running on low memory devices.

BUG=495342
Committed: https://crrev.com/4f3fde9522466af7d678eebe9f6a0a1356a0326e
Cr-Commit-Position: refs/heads/master@{#335767}

[zbowling_chromium, 2015-06-22 23:06:46]

zbowling@chromium.org changed reviewers:
+ dskiba@google.com, mariakhomenko@chromium.org

[zbowling_chromium, 2015-06-22 23:12:38]

This should hopefully do the trick.

[zbowling_chromium, 2015-06-22 23:14:34]

zbowling@chromium.org changed reviewers:
+ cbentzel@chromium.org

[zbowling_chromium, 2015-06-22 23:56:47]

The CQ bit was checked by zbowling@chromium.org

[zbowling_chromium, 2015-06-22 23:56:52]

The CQ bit was unchecked by zbowling@chromium.org

[Maria, 2015-06-23 01:54:07]

lgtm

[zbowling_chromium, 2015-06-23 02:12:50]

The CQ bit was checked by zbowling@chromium.org

[commit-bot: I haz the power, 2015-06-23 02:13:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203573002/1

[commit-bot: I haz the power, 2015-06-23 03:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 03:40:34]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[cbentzel, 2015-06-23 12:18:42]

cbentzel@chromium.org changed reviewers:
+ ttuttle@chromium.org

[cbentzel, 2015-06-23 12:20:44]

LGTM

Does this impact any tests?

https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:109:
// TODO(zbowling): remove this after domain reliability is refactored.
Can you add a link to a bug for this in the comment?

[zbowling_chromium, 2015-06-23 13:51:09]

On 2015/06/23 12:20:44, cbentzel wrote:
> LGTM
> 
> Does this impact any tests?
> 
>
https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
> (right):
> 
>
https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:109:
> // TODO(zbowling): remove this after domain reliability is refactored.
> Can you add a link to a bug for this in the comment?

Only one odd test is having trouble but I'm investigating how it's related. I
actually don't think we have too many tests that run when isLowMemDevice == true
so we are unlikely to hit anything the way it's guarded. Raises a good question.
I'll figure how many tests we actually run on low-mem/svelte devices on the
trybots.

[cbentzel, 2015-06-23 13:54:26]

Thanks for looking into it. I'm guessing many devs don't run on low-mem
devices for daily driver, so automation key to preventing regressions.

On Tue, Jun 23, 2015 at 9:51 AM <zbowling@chromium.org> wrote:

> On 2015/06/23 12:20:44, cbentzel wrote:
> > LGTM
>
> > Does this impact any tests?
>
>
>
>
https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
> > File
>
>
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
> > (right):
>
>
>
>
https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
>
>
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:109:
> > // TODO(zbowling): remove this after domain reliability is refactored.
> > Can you add a link to a bug for this in the comment?
>
> Only one odd test is having trouble but I'm investigating how it's related.
> I
> actually don't think we have too many tests that run when isLowMemDevice ==
> true
> so we are unlikely to hit anything the way it's guarded. Raises a good
> question.
> I'll figure how many tests we actually run on low-mem/svelte devices on the
> trybots.
>
> https://codereview.chromium.org/1203573002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[zbowling_chromium, 2015-06-23 17:09:02]

This breaks a completely unrelated test consistently on a trybot oddly.
Especially weird because the test that is failing is not running on a low memory
device and should be functioning the same as before.

https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1203573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:109:
// TODO(zbowling): remove this after domain reliability is refactored.
On 2015/06/23 12:20:44, cbentzel wrote:
> Can you add a link to a bug for this in the comment?

Done.

[zbowling_chromium, 2015-06-23 21:59:20]

The CQ bit was checked by zbowling@chromium.org

[zbowling_chromium, 2015-06-23 21:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbentzel@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/1203573002/#ps40001
(title: "change order so we call DeviceClassManager later")

[commit-bot: I haz the power, 2015-06-23 22:00:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1203573002/40001

[Dmitry Skiba, 2015-06-23 22:09:55]

https://codereview.chromium.org/1203573002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1203573002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:96:
private void preInflationStatupDone() {
Statup -> Startup

[commit-bot: I haz the power, 2015-06-23 22:11:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-23 22:12:26]

Patchset 3 (id:??) landed as
https://crrev.com/4f3fde9522466af7d678eebe9f6a0a1356a0326e
Cr-Commit-Position: refs/heads/master@{#335767}

[zbowling_chromium, 2015-06-23 22:41:11]

Fixed the typo.