Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1217893012: Remove deprecated v8::Object::TurnOnAccessCheck() from the V8 API. (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated v8::Object::TurnOnAccessCheck() from the V8 API. The only right way to enable access checks is to install access check callbacks on an object template via v8::ObjectTemplate::SetAccessCheckCallbacks(). It does not make sense to enable access checks on an arbitrary object. Committed: https://crrev.com/3997ae1b469617be5abbe517d61ea71481bc6638 Cr-Commit-Position: refs/heads/master@{#29439}

Patch Set 1 #

Patch Set 2 : Deoptimizer::DeoptimizeGlobalObject() removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -246 lines) Patch
M include/v8.h View 2 chunks +3 lines, -14 lines 0 comments Download
M src/api.cc View 3 chunks +2 lines, -24 lines 0 comments Download
M src/deoptimizer.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/deoptimizer.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +1 line, -77 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 13 chunks +20 lines, -56 lines 0 comments Download
M test/mjsunit/migrations.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Igor Sheludko
Toon: PTAL Jochen: FYI
5 years, 5 months ago (2015-07-01 19:37:01 UTC) #2
Igor Sheludko
5 years, 5 months ago (2015-07-01 20:13:15 UTC) #4
Toon Verwaest
Awesome, thanks. Lgtm
5 years, 5 months ago (2015-07-01 20:18:45 UTC) #5
jochen (gone - plz use gerrit)
On 2015/07/01 at 20:18:45, verwaest wrote: > Awesome, thanks. Lgtm lgtm
5 years, 5 months ago (2015-07-02 06:58:44 UTC) #6
jochen (gone - plz use gerrit)
On 2015/07/01 at 20:18:45, verwaest wrote: > Awesome, thanks. Lgtm lgtm
5 years, 5 months ago (2015-07-02 06:58:44 UTC) #7
Igor Sheludko
Also removed Deoptimizer::DeoptimizeGlobalObject().
5 years, 5 months ago (2015-07-02 08:19:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217893012/20001
5 years, 5 months ago (2015-07-02 08:21:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-02 09:05:43 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 09:05:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3997ae1b469617be5abbe517d61ea71481bc6638
Cr-Commit-Position: refs/heads/master@{#29439}

Powered by Google App Engine
This is Rietveld 408576698