Remove deprecated v8::Object::TurnOnAccessCheck() from the V8 API.

test/cctest/test-api-interceptors.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "test/cctest/test-api.h"
 
 #include "include/v8-util.h"
 #include "src/api.h"
@@ skipping 1640 matching lines @@
       "    if (v != 0) throw 'Wrong value ' + v + ' at iteration ' + i;"
       "  }"
       "  'PASSED'"
       "} catch(e) {"
       "  e"
       "}";
   ExpectString(code, "PASSED");
 }
 
 
+static bool AccessAlwaysBlocked(Local<v8::Object> global, Local<Value> name,
+                                v8::AccessType type, Local<Value> data) {
+  return false;
+}
+
+
 THREADED_TEST(IndexedInterceptorWithAccessorCheck) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
   templ->SetHandler(
       v8::IndexedPropertyHandlerConfiguration(IdentityIndexedPropertyGetter));
 
+  templ->SetAccessCheckCallbacks(AccessAlwaysBlocked, nullptr);
+
   LocalContext context;
   Local<v8::Object> obj = templ->NewInstance();
-  obj->TurnOnAccessCheck();
   context->Global()->Set(v8_str("obj"), obj);
 
   const char* code =
       "var result = 'PASSED';"
       "for (var i = 0; i < 100; i++) {"
       "  try {"
       "    var v = obj[0];"
       "    result = 'Wrong value ' + v + ' at iteration ' + i;"
       "    break;"
       "  } catch (e) {"
       "    /* pass */"
       "  }"
       "}"
       "result";
   ExpectString(code, "PASSED");
 }
 
 
-THREADED_TEST(IndexedInterceptorWithAccessorCheckSwitchedOn) {
-  i::FLAG_allow_natives_syntax = true;
-  v8::Isolate* isolate = CcTest::isolate();
-  v8::HandleScope scope(isolate);
-  Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
-  templ->SetHandler(
-      v8::IndexedPropertyHandlerConfiguration(IdentityIndexedPropertyGetter));
-
-  LocalContext context;
-  Local<v8::Object> obj = templ->NewInstance();
-  context->Global()->Set(v8_str("obj"), obj);
-
-  const char* code =
-      "var result = 'PASSED';"
-      "for (var i = 0; i < 100; i++) {"
-      "  var expected = i;"
-      "  if (i == 5) {"
-      "    %EnableAccessChecks(obj);"
-      "  }"
-      "  try {"
-      "    var v = obj[i];"
-      "    if (i == 5) {"
-      "      result = 'Should not have reached this!';"
-      "      break;"
-      "    } else if (v != expected) {"
-      "      result = 'Wrong value ' + v + ' at iteration ' + i;"
-      "      break;"
-      "    }"
-      "  } catch (e) {"
-      "    if (i != 5) {"
-      "      result = e;"
-      "    }"
-      "  }"
-      "  if (i == 5) %DisableAccessChecks(obj);"
-      "}"
-      "result";
-  ExpectString(code, "PASSED");
-}
-
-
 THREADED_TEST(IndexedInterceptorWithDifferentIndices) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
   templ->SetHandler(
       v8::IndexedPropertyHandlerConfiguration(IdentityIndexedPropertyGetter));
 
   LocalContext context;
   Local<v8::Object> obj = templ->NewInstance();
   context->Global()->Set(v8_str("obj"), obj);
@@ skipping 1229 matching lines @@
 
 }  // namespace
 
 
 THREADED_TEST(NamedAllCanReadInterceptor) {
   auto isolate = CcTest::isolate();
   v8::HandleScope handle_scope(isolate);
   LocalContext context;
 
   AccessCheckData access_check_data;
-  access_check_data.result = false;
+  access_check_data.result = true;
   access_check_data.count = 0;
 
   ShouldInterceptData intercept_data_0;
   intercept_data_0.value = 239;
   intercept_data_0.should_intercept = true;
 
   ShouldInterceptData intercept_data_1;
   intercept_data_1.value = 165;
   intercept_data_1.should_intercept = false;
 
@@ skipping 11 matching lines @@
     v8::NamedPropertyHandlerConfiguration conf(ShouldNamedInterceptor);
     conf.flags = v8::PropertyHandlerFlags::kAllCanRead;
     conf.data =
         BuildWrappedObject<ShouldInterceptData>(isolate, &intercept_data_1);
     intercepted_1->SetHandler(conf);
   }
 
   auto checked = v8::ObjectTemplate::New(isolate);
   checked->SetAccessCheckCallbacks(
       SimpleAccessChecker, nullptr,
-      BuildWrappedObject<AccessCheckData>(isolate, &access_check_data), false);
+      BuildWrappedObject<AccessCheckData>(isolate, &access_check_data));
 
   context->Global()->Set(v8_str("intercepted_0"), intercepted_0->NewInstance());
   context->Global()->Set(v8_str("intercepted_1"), intercepted_1->NewInstance());
   auto checked_instance = checked->NewInstance();
   checked_instance->Set(v8_str("whatever"), v8_num(17));
   context->Global()->Set(v8_str("checked"), checked_instance);
   CompileRun(
       "checked.__proto__ = intercepted_1;"
       "intercepted_1.__proto__ = intercepted_0;");
 
-  checked_instance->TurnOnAccessCheck();
-  CHECK_EQ(0, access_check_data.count);
+  CHECK_EQ(3, access_check_data.count);
 
-  access_check_data.result = true;
   ExpectInt32("checked.whatever", 17);
   CHECK(!CompileRun("Object.getOwnPropertyDescriptor(checked, 'whatever')")
              ->IsUndefined());
-  CHECK_EQ(2, access_check_data.count);
+  CHECK_EQ(5, access_check_data.count);
 
   access_check_data.result = false;
   ExpectInt32("checked.whatever", intercept_data_0.value);
   {
     v8::TryCatch try_catch(isolate);
     CompileRun("Object.getOwnPropertyDescriptor(checked, 'whatever')");
     CHECK(try_catch.HasCaught());
   }
-  CHECK_EQ(4, access_check_data.count);
+  CHECK_EQ(7, access_check_data.count);
 
   intercept_data_1.should_intercept = true;
   ExpectInt32("checked.whatever", intercept_data_1.value);
   {
     v8::TryCatch try_catch(isolate);
     CompileRun("Object.getOwnPropertyDescriptor(checked, 'whatever')");
     CHECK(try_catch.HasCaught());
   }
-  CHECK_EQ(6, access_check_data.count);
+  CHECK_EQ(9, access_check_data.count);
 }
 
 
 THREADED_TEST(IndexedAllCanReadInterceptor) {
   auto isolate = CcTest::isolate();
   v8::HandleScope handle_scope(isolate);
   LocalContext context;
 
   AccessCheckData access_check_data;
-  access_check_data.result = false;
+  access_check_data.result = true;
   access_check_data.count = 0;
 
   ShouldInterceptData intercept_data_0;
   intercept_data_0.value = 239;
   intercept_data_0.should_intercept = true;
 
   ShouldInterceptData intercept_data_1;
   intercept_data_1.value = 165;
   intercept_data_1.should_intercept = false;
 
@@ skipping 11 matching lines @@
     v8::IndexedPropertyHandlerConfiguration conf(ShouldIndexedInterceptor);
     conf.flags = v8::PropertyHandlerFlags::kAllCanRead;
     conf.data =
         BuildWrappedObject<ShouldInterceptData>(isolate, &intercept_data_1);
     intercepted_1->SetHandler(conf);
   }
 
   auto checked = v8::ObjectTemplate::New(isolate);
   checked->SetAccessCheckCallbacks(
       SimpleAccessChecker, nullptr,
-      BuildWrappedObject<AccessCheckData>(isolate, &access_check_data), false);
+      BuildWrappedObject<AccessCheckData>(isolate, &access_check_data));
 
   context->Global()->Set(v8_str("intercepted_0"), intercepted_0->NewInstance());
   context->Global()->Set(v8_str("intercepted_1"), intercepted_1->NewInstance());
   auto checked_instance = checked->NewInstance();
   context->Global()->Set(v8_str("checked"), checked_instance);
   checked_instance->Set(15, v8_num(17));
   CompileRun(
       "checked.__proto__ = intercepted_1;"
       "intercepted_1.__proto__ = intercepted_0;");
 
-  checked_instance->TurnOnAccessCheck();
-  CHECK_EQ(0, access_check_data.count);
+  CHECK_EQ(3, access_check_data.count);
 
   access_check_data.result = true;
   ExpectInt32("checked[15]", 17);
   CHECK(!CompileRun("Object.getOwnPropertyDescriptor(checked, '15')")
              ->IsUndefined());
-  CHECK_EQ(2, access_check_data.count);
+  CHECK_EQ(5, access_check_data.count);
 
   access_check_data.result = false;
   ExpectInt32("checked[15]", intercept_data_0.value);
   {
     v8::TryCatch try_catch(isolate);
     CompileRun("Object.getOwnPropertyDescriptor(checked, '15')");
     CHECK(try_catch.HasCaught());
   }
-  CHECK_EQ(4, access_check_data.count);
+  CHECK_EQ(7, access_check_data.count);
 
   intercept_data_1.should_intercept = true;
   ExpectInt32("checked[15]", intercept_data_1.value);
   {
     v8::TryCatch try_catch(isolate);
     CompileRun("Object.getOwnPropertyDescriptor(checked, '15')");
     CHECK(try_catch.HasCaught());
   }
-  CHECK_EQ(6, access_check_data.count);
+  CHECK_EQ(9, access_check_data.count);
 }
 
 
 THREADED_TEST(NonMaskingInterceptorOwnProperty) {
   auto isolate = CcTest::isolate();
   v8::HandleScope handle_scope(isolate);
   LocalContext context;
 
   ShouldInterceptData intercept_data;
   intercept_data.value = 239;
@@ skipping 171 matching lines @@
       "var obj = intercepted_1;"
       "obj.x = 4;"
       "eval('obj.x');"
       "eval('obj.x');"
       "eval('obj.x');"
       "obj = intercepted_2;"
       "obj.x = 9;"
       "eval('obj.x');",
       9);
 }