Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: runtime/observatory/tests/service/break_on_activation_test.dart

Issue 1217823009: Make VM event streams look like real dart streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge with master Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/break_on_activation_test.dart
diff --git a/runtime/observatory/tests/service/break_on_activation_test.dart b/runtime/observatory/tests/service/break_on_activation_test.dart
index b26695406bf9bd99b17b1e6eb1f283aaafaecb82..d7418a50478002a26586e9e50495ea667112fc4f 100644
--- a/runtime/observatory/tests/service/break_on_activation_test.dart
+++ b/runtime/observatory/tests/service/break_on_activation_test.dart
@@ -54,14 +54,14 @@ var tests = [
var breaksHit = 0;
- var subscription;
- subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kPauseBreakpoint) {
- print("Hit breakpoint ${event.breakpoint}");
- breaksHit++;
- isolate.resume();
- }
- });
+ var subscriptionFuture = isolate.vm.listenEventStream(
+ VM.kDebugStream, (ServiceEvent event) {
+ if (event.kind == ServiceEvent.kPauseBreakpoint) {
+ print("Hit breakpoint ${event.breakpoint}");
+ breaksHit++;
+ isolate.resume();
+ }
+ });
valueOfField(String name) async {
var field = rootLib.variables.singleWhere((v) => v.name == name);
@@ -91,7 +91,7 @@ var tests = [
expect(res is Instance, isTrue); // Not error.
expect(breaksHit, equals(1));
- await subscription.cancel();
+ await cancelFutureSubscription(subscriptionFuture);
},
(Isolate isolate) async {
@@ -99,14 +99,14 @@ var tests = [
var breaksHit = 0;
- var subscription;
- subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kPauseBreakpoint) {
- print("Hit breakpoint ${event.breakpoint}");
- breaksHit++;
- isolate.resume();
- }
- });
+ var subscriptionFuture = isolate.vm.listenEventStream(
+ VM.kDebugStream, (ServiceEvent event) {
+ if (event.kind == ServiceEvent.kPauseBreakpoint) {
+ print("Hit breakpoint ${event.breakpoint}");
+ breaksHit++;
+ isolate.resume();
+ }
+ });
valueOfField(String name) async {
var field = rootLib.variables.singleWhere((v) => v.name == name);
@@ -135,7 +135,7 @@ var tests = [
expect(res is Instance, isTrue); // Not error.
expect(breaksHit, equals(1));
- await subscription.cancel();
+ await cancelFutureSubscription(subscriptionFuture);
},
(Isolate isolate) async {
@@ -143,14 +143,14 @@ var tests = [
var breaksHit = 0;
- var subscription;
- subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kPauseBreakpoint) {
- print("Hit breakpoint ${event.breakpoint}");
- breaksHit++;
- isolate.resume();
- }
- });
+ var subscriptionFuture = isolate.vm.listenEventStream(
+ VM.kDebugStream, (ServiceEvent event) {
+ if (event.kind == ServiceEvent.kPauseBreakpoint) {
+ print("Hit breakpoint ${event.breakpoint}");
+ breaksHit++;
+ isolate.resume();
+ }
+ });
valueOfField(String name) async {
var field = rootLib.variables.singleWhere((v) => v.name == name);
@@ -200,7 +200,7 @@ var tests = [
expect(res is Instance, isTrue); // Not error.
expect(breaksHit, equals(4));
- await subscription.cancel();
+ await cancelFutureSubscription(subscriptionFuture);
},
];

Powered by Google App Engine
This is Rietveld 408576698