runtime/observatory/tests/service/async_generator_breakpoint_test.dart - Issue 1217823009: Make VM event streams look like real dart streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/async_generator_breakpoint_test.dart

Issue 1217823009: Make VM event streams look like real dart streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge with master Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/observatory/tests/service/break_on_activation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/async_generator_breakpoint_test.dart

diff --git a/runtime/observatory/tests/service/async_generator_breakpoint_test.dart b/runtime/observatory/tests/service/async_generator_breakpoint_test.dart

index c8a33e3c25dc8d1112c09eb187de8d091cdb06b0..4cfc076c5286fe5ca8069781e56f6aa34e200638 100644

--- a/runtime/observatory/tests/service/async_generator_breakpoint_test.dart

+++ b/runtime/observatory/tests/service/async_generator_breakpoint_test.dart

@@ -69,7 +69,8 @@ testAsync(Isolate isolate) async {

expect(result.valueAsString, equals('true'));

});

- await for (ServiceEvent event in isolate.vm.events.stream) {

+ var stream = await isolate.vm.getEventStream(VM.kDebugStream);

+ await for (ServiceEvent event in stream) {

if (event.kind == ServiceEvent.kPauseBreakpoint) {

var bp = event.breakpoint;

print('Hit $bp');

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/observatory/tests/service/break_on_activation_test.dart » ('j') | no next file with comments »