tools/perf/benchmarks/oilpan_gc_times.py - Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/oilpan_gc_times.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/oilpan_gc_times.py

diff --git a/tools/perf/benchmarks/oilpan_gc_times.py b/tools/perf/benchmarks/oilpan_gc_times.py

index 0a7970661111d6664b9c8176553a0f26c6c6c84f..c429764bc99645c2c441522236fc6dfbd3f7f95f 100644

--- a/tools/perf/benchmarks/oilpan_gc_times.py

+++ b/tools/perf/benchmarks/oilpan_gc_times.py

@@ -22,9 +22,9 @@ class OilpanGCTimesBlinkPerfStress(perf_benchmark.PerfBenchmark):

def Name(cls):

return 'oilpan_gc_times.blink_perf_stress'

- def CreatePageSet(self, options):

+ def CreateStorySet(self, options):

path = os.path.join(blink_perf.BLINK_PERF_BASE_DIR, 'BlinkGC')

- return blink_perf.CreatePageSetFromPath(path, blink_perf.SKIPPED_FILE)

+ return blink_perf.CreateStorySetFromPath(path, blink_perf.SKIPPED_FILE)

class OilpanGCTimesSmoothnessAnimation(perf_benchmark.PerfBenchmark):

« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/page_cycler.py » ('j') | no next file with comments »