Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/mark-compact.cc

Issue 12177011: Reduces memory consumption for parallel sweeping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index c37e54dd6cf15381c580ab4f22d167c2d5969590..e828f9c7ce8d3a39280388907de90eba9f7fb40c 100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -3854,22 +3854,21 @@ void MarkCompactCollector::SweepSpaces() {
SweepSpace(heap()->old_pointer_space(), how_to_sweep);
SweepSpace(heap()->old_data_space(), how_to_sweep);
- RemoveDeadInvalidatedCode();
- SweepSpace(heap()->code_space(), PRECISE);
-
- SweepSpace(heap()->cell_space(), PRECISE);
-
- EvacuateNewSpaceAndCandidates();
-
if (how_to_sweep == PARALLEL_CONSERVATIVE) {
- // TODO(hpayer): The starting of the sweeper threads should be after
- // SweepSpace old data space.
+ // TODO(hpayer): fix race with concurrent sweeper
StartSweeperThreads();
if (FLAG_parallel_sweeping && !FLAG_concurrent_sweeping) {
WaitUntilSweepingCompleted();
}
}
+ RemoveDeadInvalidatedCode();
+ SweepSpace(heap()->code_space(), PRECISE);
+
+ SweepSpace(heap()->cell_space(), PRECISE);
+
+ EvacuateNewSpaceAndCandidates();
+
// ClearNonLiveTransitions depends on precise sweeping of map space to
// detect whether unmarked map became dead in this collection or in one
// of the previous ones.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698