Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1217553005: [turbofan] Fix value output count for the Start node. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix value output count for the Start node. The value output count for Start is currently off by 1 for code stubs, because the CommonOperatorBuilder hardcodes the receiver parameter. R=mstarzinger@chromium.org Committed: https://crrev.com/870ce53a53fb53c651b930c0d57e4ddae008568a Cr-Commit-Position: refs/heads/master@{#29490}

Patch Set 1 #

Patch Set 2 : Fix test-run-stubs.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-06 11:35:31 UTC) #1
Benedikt Meurer
Hey Michi, The cleanup we talked about. This way context specialization won't need a magic ...
5 years, 5 months ago (2015-07-06 11:36:33 UTC) #2
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-06 11:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217553005/20001
5 years, 5 months ago (2015-07-06 11:40:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 12:11:54 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 12:12:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/870ce53a53fb53c651b930c0d57e4ddae008568a
Cr-Commit-Position: refs/heads/master@{#29490}

Powered by Google App Engine
This is Rietveld 408576698