Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4122)

Unified Diff: src/compiler/verifier.cc

Issue 1217553005: [turbofan] Fix value output count for the Start node. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test-run-stubs.cc Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/common-operator.cc ('k') | test/cctest/compiler/simplified-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 5f1df77736efd3081d40863f8334d11ea86aaa69..690fd045779fa7486282d88eed39b2ad21a061fb 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -318,13 +318,13 @@ void Verifier::Visitor::Check(Node* node) {
case IrOpcode::kParameter: {
// Parameters have the start node as inputs.
CHECK_EQ(1, input_count);
- CHECK_EQ(IrOpcode::kStart,
- NodeProperties::GetValueInput(node, 0)->opcode());
// Parameter has an input that produces enough values.
- int index = OpParameter<int>(node);
- Node* input = NodeProperties::GetValueInput(node, 0);
+ int const index = ParameterIndexOf(node->op());
+ Node* const start = NodeProperties::GetValueInput(node, 0);
+ CHECK_EQ(IrOpcode::kStart, start->opcode());
// Currently, parameter indices start at -1 instead of 0.
- CHECK_GT(input->op()->ValueOutputCount(), index + 1);
+ CHECK_LE(-1, index);
+ CHECK_LT(index + 1, start->op()->ValueOutputCount());
// Type can be anything.
CheckUpperIs(node, Type::Any());
break;
« no previous file with comments | « src/compiler/common-operator.cc ('k') | test/cctest/compiler/simplified-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698