Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12173002: Revert 179608 (Closed)

Created:
7 years, 10 months ago by sky
Modified:
7 years, 10 months ago
Reviewers:
tfarina
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert 179608 > views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cc > > simple_message_box_win.cc is not be needed nor compatible with the desktop-aura > transition. It also uses the win32 appearance not the new Chrome style > appearance currently in development. So it's bad twice ;) > > Just kill it and that eases the work that will need to be done later. > > By enabling simple_message_box_views on Windows means that it will be used for all > ShowMessageBox() dialogs instead of current Windows MessageBox. > > BUG=166075, 54988 > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/12042083 Reverting as causes crashes on windows. Specifically this code is not necessarily executed on the UI thread and views is not designed to be used on anything but the UI thread. TBR=tfarina@chromium.org BUG=173751 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --1 lines) Patch
A + chrome/browser/ui/views/simple_message_box_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
7 years, 10 months ago (2013-02-02 00:16:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698