Chromium Code Reviews
DescriptionRevert 179608
> views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cc
>
> simple_message_box_win.cc is not be needed nor compatible with the desktop-aura
> transition. It also uses the win32 appearance not the new Chrome style
> appearance currently in development. So it's bad twice ;)
>
> Just kill it and that eases the work that will need to be done later.
>
> By enabling simple_message_box_views on Windows means that it will be used for all
> ShowMessageBox() dialogs instead of current Windows MessageBox.
>
> BUG=166075, 54988
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/12042083
Reverting as causes crashes on windows. Specifically this code is
not necessarily executed on the UI thread and views is not designed to
be used on anything but the UI thread.
TBR=tfarina@chromium.org
BUG=173751
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180208
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|
||||||||||||||||||||||||||||