views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cc

views: Remove simple_message_box_win.cc in favor of simple_message_box_views.cc

simple_message_box_win.cc is not be needed nor compatible with the desktop-aura
transition. It also uses the win32 appearance not the new Chrome style
appearance currently in development. So it's bad twice ;)

Just kill it and that eases the work that will need to be done later.

By enabling simple_message_box_views on Windows means that it will be used for all
ShowMessageBox() dialogs instead of current Windows MessageBox.

BUG=166075, 54988
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179608

[Ben Goodger (Google), 2013-01-28 17:39:43]

Can you make a screenshot to show that SMBV works as-is on windows?

[tfarina, 2013-01-28 17:50:55]

No, I do not have a Windows machine capable of building Chrome. I'd have to
ask someone to patch and try this for me.

(no money to buy a z600/z620).


-- 
Thiago

[Ben Goodger (Google), 2013-01-28 18:30:21]

Mike, do you have a non-aura Windows build around you can patch Thiago's
change into and provide a screenshot of one of the dialogs that use simple
message box?

-Ben


On Mon, Jan 28, 2013 at 9:50 AM, Thiago Farina <tfarina@chromium.org> wrote:

> No, I do not have a Windows machine capable of building Chrome. I'd have
> to ask someone to patch and try this for me.
>
> (no money to buy a z600/z620).
>
>
> --
> Thiago
>

[msw, 2013-01-28 23:43:24]

I posted a picture comparing the dialog style with[out] this patch and with[out]
--enable-new-dialog-style: http://crbug.com/54988#c16

This CL LGTM if the new intermediary style is acceptable while I finish up the
new dialog styling for http://crbug.com/166075 (wait for Ben's review).

[Ben Goodger (Google), 2013-01-29 22:19:48]

yeah that's fine lgtm


On Mon, Jan 28, 2013 at 3:43 PM, <msw@chromium.org> wrote:

> I posted a picture comparing the dialog style with[out] this patch and
> with[out]
> --enable-new-dialog-style: http://crbug.com/54988#c16
>
> This CL LGTM if the new intermediary style is acceptable while I finish up
> the
> new dialog styling for http://crbug.com/166075 (wait for Ben's review).
>
>
https://codereview.chromium.**org/12042083/<https://codereview.chromium.org/1...
>

[msw, 2013-01-29 22:22:42]

Oh, I didn't notice right away that the icon is missing.
(that little warning triangle sign, not sure if that's ok...)