Move headers used by headers in include/ to include/private.

Move headers used by headers in include/ to include/private.

Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661

Committed: https://skia.googlesource.com/skia/+/928e16565f3e69cd6661e9ad300ac17e3f33c0c8

For next time, figure out what's up with
https://codereview.chromium.org/1212613013

[mtklein_C, 2015-06-30 21:30:05]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2015-06-30 21:30:06]

Please note the changes to PRESUBMIT.py

[reed1, 2015-07-01 13:07:19]

lgtm

Perhaps we want to consider a stock comment/etc. at the top of these headers.

e.g. PRIVATE INCLUDE -- DO NOT USE DIRECTLY

.. or not.

[mtklein, 2015-07-01 13:28:16]

On 2015/07/01 13:07:19, reed1 wrote:
> lgtm
> 
> Perhaps we want to consider a stock comment/etc. at the top of these headers.
> 
> e.g. PRIVATE INCLUDE -- DO NOT USE DIRECTLY
> 
> .. or not.

I'm thinking something like,

SkSomePublicHeader.h
==================
....
#include "SkBitmap.h"
#include "SkCanvas.h"
...
#define SK_PRIVATE_INCLUDES
   #include "../private/SkTHash.h"   // or whatever
   #include "../private/SkRecords.h"
#undef SK_PRIVATE_INCLUDES
...

where all the private headers start with

#ifndef SK_PRIVATE_INCLUDES
  #error "This header is private to Skia.  Do not include it directly."
#endif

[mtklein, 2015-07-01 13:51:56]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-07-01 13:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/20001

[commit-bot: I haz the power, 2015-07-01 13:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 13:57:02]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[mtklein, 2015-07-01 14:06:33]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-07-01 14:06:34]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1217293004/#ps40001
(title: "remove SkTLogic from gyp file")

[commit-bot: I haz the power, 2015-07-01 14:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/40001

[commit-bot: I haz the power, 2015-07-01 14:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 14:12:40]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[mtklein, 2015-07-01 14:15:07]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-07-01 14:15:08]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1217293004/#ps60001
(title: "update views.gyp")

[commit-bot: I haz the power, 2015-07-01 14:15:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/60001

[mtklein, 2015-07-01 14:18:07]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-07-01 14:18:08]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1217293004/#ps80001
(title: "xps.gyp")

[commit-bot: I haz the power, 2015-07-01 14:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/80001

[commit-bot: I haz the power, 2015-07-01 14:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 14:21:58]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein, 2015-07-01 15:04:56]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-07-01 15:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1217293004/#ps100001
(title: "example.gyp")

[commit-bot: I haz the power, 2015-07-01 15:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/100001

[commit-bot: I haz the power, 2015-07-01 15:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 15:08:49]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein, 2015-07-01 15:33:45]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-07-01 15:33:45]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1217293004/#ps120001
(title: "move SkChecksum too")

[commit-bot: I haz the power, 2015-07-01 15:34:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/120001

[commit-bot: I haz the power, 2015-07-01 15:41:19]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661

[mtklein_C, 2015-07-01 18:54:26]

Going to try again.

[mtklein_C, 2015-07-01 18:54:35]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2015-07-01 18:54:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217293004/120001

[commit-bot: I haz the power, 2015-07-01 18:55:50]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/928e16565f3e69cd6661e9ad300ac17e3f33c0c8