Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 1216933011: [turbofan] Enable tail calls for %_CallFunction. (Closed)

Created:
5 years, 5 months ago by danno
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable tail calls for %_CallRuntime. This involves: - Enabling the tail call optimization reducer in all cases. - Adding an addition flag to CallFunctionParameters to mark call sites that can be tail-called enabled. - Only set the tail-call flag for %_CallFunction. R=bmeurer@chromium.org Committed: https://crrev.com/1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0 Cr-Commit-Position: refs/heads/master@{#29436}

Patch Set 1 #

Patch Set 2 : Platform ports #

Patch Set 3 : Fix platform ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -83 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 5 chunks +10 lines, -3 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M src/compiler/linkage.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +58 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
A test/mjsunit/call-runtime-tail.js View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danno
PTAL
5 years, 5 months ago (2015-07-01 16:27:26 UTC) #2
Benedikt Meurer
LGTM.
5 years, 5 months ago (2015-07-02 04:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216933011/40001
5 years, 5 months ago (2015-07-02 05:58:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-02 06:20:08 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 06:20:21 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0
Cr-Commit-Position: refs/heads/master@{#29436}

Powered by Google App Engine
This is Rietveld 408576698