Issue 1216933008: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Layout test 3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216933008: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Layout test 3/3) (Closed)

Created:
5 years, 5 months ago by jungkees

Modified:
5 years, 5 months ago

Reviewers:
michaeln, falken, dw.im, nhiroki, kinuko, lgombos

CC:
blink-reviews, michaeln, jsbell, tzik, serviceworker-reviews, nhiroki, dglazkov+blink, kinuko+serviceworker, horo

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Layout test 3/3) Migrate ServiceWorkerVerion's int64 type version_id to std::string type version_uuid: - Replace next_avail_version_id semantic with a UUID based versioning. - Migrate leveldb schema . Deprecate INITDATA_NEXT_VERSION_ID . Change data format for ServiceWorkerResourceRecord Surface ServiceWorker.id attribute as per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#client-id-attribute Spec issue: https://github.com/slightlyoff/ServiceWorker/issues/635 Companion CL (Blink): https://codereview.chromium.org/1216093003/ Companion CL (Chromium): https://codereview.chromium.org/1221643014/ BUG=470031

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -0 lines)			Patch
	A	LayoutTests/http/tests/serviceworker/serviceworkerobject-id.html	View		1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 4 (2 generated)

jungkees

5 years, 5 months ago (2015-07-24 02:06:28 UTC) #4

Message was sent while issue was closed.

Closed the CL as per the consensus at f2f to punt ServiceWorker.id to v2 or
since there's not a clear
use case yet.