sky/engine/core/painting/PictureRecorder.h - Issue 1216833003: Make rendering use PaintingNodes for increased efficiency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/painting/PictureRecorder.h

Issue 1216833003: Make rendering use PaintingNodes for increased efficiency. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Feedback fixes plus missing critical line that makes it work Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/painting/PictureRecorder.h

diff --git a/sky/engine/core/painting/PictureRecorder.h b/sky/engine/core/painting/PictureRecorder.h

index e01c66a310d388822321206bb23f5809ce0864e3..02c7d720c7bea50b33fcb850f92adb04c846d3e9 100644

--- a/sky/engine/core/painting/PictureRecorder.h

+++ b/sky/engine/core/painting/PictureRecorder.h

@@ -5,6 +5,7 @@

#ifndef SKY_ENGINE_CORE_PAINTING_PICTURERECORDER_H_

#define SKY_ENGINE_CORE_PAINTING_PICTURERECORDER_H_

+#include "sky/engine/core/painting/Rect.h"

#include "sky/engine/tonic/dart_wrappable.h"

#include "sky/engine/wtf/PassRefPtr.h"

#include "sky/engine/wtf/RefCounted.h"

@@ -28,7 +29,7 @@ public:

~PictureRecorder();

// PassRefPtr<Canvas> beginRecording(double width, double height);

- SkCanvas* beginRecording(double width, double height);

+ SkCanvas* beginRecording(Rect bounds);

PassRefPtr<Picture> endRecording();

PassRefPtr<Drawable> endRecordingAsDrawable();

bool isRecording();