sky/engine/core/painting/PictureRecorder.cpp - Issue 1216833003: Make rendering use PaintingNodes for increased efficiency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/painting/PictureRecorder.cpp

Issue 1216833003: Make rendering use PaintingNodes for increased efficiency. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Feedback fixes plus missing critical line that makes it work Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/painting/PictureRecorder.cpp

diff --git a/sky/engine/core/painting/PictureRecorder.cpp b/sky/engine/core/painting/PictureRecorder.cpp

index 08cb42317ccb0330e9165eb29220b2712856e8ea..cbc7cd1bbf9ba071d773b9c16641460e50f66124 100644

--- a/sky/engine/core/painting/PictureRecorder.cpp

+++ b/sky/engine/core/painting/PictureRecorder.cpp

@@ -22,9 +22,9 @@ bool PictureRecorder::isRecording() {

return m_canvas && m_canvas->isRecording();

}

-SkCanvas* PictureRecorder::beginRecording(double width, double height)

+SkCanvas* PictureRecorder::beginRecording(Rect bounds)

{

- return m_pictureRecorder->beginRecording(width, height);

+ return m_pictureRecorder->beginRecording(bounds.sk_rect);

}

PassRefPtr<Picture> PictureRecorder::endRecording()