sky/engine/core/painting/Canvas.cpp - Issue 1216833003: Make rendering use PaintingNodes for increased efficiency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/painting/Canvas.cpp

Issue 1216833003: Make rendering use PaintingNodes for increased efficiency. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Feedback fixes plus missing critical line that makes it work Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/painting/Canvas.cpp

diff --git a/sky/engine/core/painting/Canvas.cpp b/sky/engine/core/painting/Canvas.cpp

index 33bfc09201b6c864e4a39825521c1c9c0f4e4068..8483bc75ec06cbb06edf3a2dcb43417ea23834d0 100644

--- a/sky/engine/core/painting/Canvas.cpp

+++ b/sky/engine/core/painting/Canvas.cpp

@@ -207,4 +207,12 @@ void Canvas::drawDrawable(Drawable* drawable)

m_canvas->drawDrawable(drawable->toSkia());

}

+void Canvas::drawPaintingNode(PaintingNode* paintingNode)

+ if (!m_canvas)

+ return;

+ ASSERT(paintingNode);

+ m_canvas->drawDrawable(paintingNode->toSkia());

} // namespace blink