sky/engine/core/core.gni - Issue 1216833003: Make rendering use PaintingNodes for increased efficiency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/core.gni

Issue 1216833003: Make rendering use PaintingNodes for increased efficiency. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Feedback fixes plus missing critical line that makes it work Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/core.gni

diff --git a/sky/engine/core/core.gni b/sky/engine/core/core.gni

index aec6c158f4142db1686bfdb00e91f98223bd936e..e680d1f2a873a7d88241f85cc7cfe4f72db84579 100644

--- a/sky/engine/core/core.gni

+++ b/sky/engine/core/core.gni

@@ -800,6 +800,8 @@ sky_core_files = [

"painting/PaintingCallback.h",

"painting/PaintingContext.cpp",

"painting/PaintingContext.h",

+ "painting/PaintingNode.cpp",

+ "painting/PaintingNode.h",

"painting/PaintingStyle.h",

"painting/PaintingTasks.cpp",

"painting/PaintingTasks.h",

@@ -1073,6 +1075,7 @@ core_idl_files = get_path_info([

"painting/LayoutRoot.idl",

"painting/MaskFilter.idl",

"painting/Paint.idl",

+ "painting/PaintingNode.idl",

"painting/Path.idl",

"painting/Picture.idl",

"painting/PictureRecorder.idl",

« no previous file with comments | « no previous file | sky/engine/core/painting/Canvas.h » ('j') | sky/engine/core/painting/PaintingNode.h » ('J')