Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: self review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/touchui/touch_selection_menu_runner_views.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index 8903650d45038bde4601fb5460873bc486ae79c5..b4786d0eef4a29981f802cb7c6ee07332746eab9 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -392,8 +392,8 @@ LabelButton* DialogClientView::CreateDialogButton(ui::DialogButton type) {
GetDialogDelegate()->ShouldDefaultButtonBeBlue()) {
button = new BlueButton(this, title);
} else {
- button = new LabelButton(this, title);
- button->SetStyle(Button::STYLE_BUTTON);
+ button = new LabelButton(this);
+ button->InitAsButton(title);
}
button->SetFocusable(true);
« no previous file with comments | « ui/views/touchui/touch_selection_menu_runner_views.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698