ui/views/touchui/touch_selection_menu_runner_views.cc - Issue 1216673005: views::LabelButton should not call virtual methods from its constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_selection_menu_runner_views.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor

Patch Set: self review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/touchui/touch_selection_menu_runner_views.cc

diff --git a/ui/views/touchui/touch_selection_menu_runner_views.cc b/ui/views/touchui/touch_selection_menu_runner_views.cc

index 6f44e526957c84f4f8ac1b2e7d82f29eb5755926..a643072aca540961f55829a0563a00afb8ab481d 100644

--- a/ui/views/touchui/touch_selection_menu_runner_views.cc

+++ b/ui/views/touchui/touch_selection_menu_runner_views.cc

@@ -161,7 +161,8 @@ Button* TouchSelectionMenuRunnerViews::Menu::CreateButton(

int tag) {

base::string16 label =

gfx::RemoveAcceleratorChar(title, '&', nullptr, nullptr);

- LabelButton* button = new LabelButton(this, label);

+ LabelButton* button = new LabelButton(this);

+ button->InitAsTextbutton(label);

button->SetMinSize(gfx::Size(kMenuButtonMinWidth, kMenuButtonMinHeight));

button->SetFocusable(true);

button->set_request_focus_on_press(false);

« no previous file with comments | « ui/views/focus/focus_traversal_unittest.cc ('k') | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »