Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: ui/views/controls/button/custom_button_unittest.cc

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: selfnits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/custom_button_unittest.cc
diff --git a/ui/views/controls/button/custom_button_unittest.cc b/ui/views/controls/button/custom_button_unittest.cc
index de3be98fe5541c63730f7c00a7ab67cf52cfcee3..c632aca170e4b2c8d24dc9e9cc0e10178471d5f0 100644
--- a/ui/views/controls/button/custom_button_unittest.cc
+++ b/ui/views/controls/button/custom_button_unittest.cc
@@ -215,7 +215,8 @@ TEST_F(CustomButtonTest, GestureEventsSetState) {
TEST_F(CustomButtonTest, AsCustomButton) {
base::string16 text;
- LabelButton label_button(NULL, text);
+ LabelButton label_button(nullptr);
+ label_button.Init(text);
EXPECT_TRUE(CustomButton::AsCustomButton(&label_button));
ImageButton image_button(NULL);

Powered by Google App Engine
This is Rietveld 408576698