Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216543005: Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed)

Created:
5 years, 5 months ago by tapted
Modified:
5 years, 5 months ago
Reviewers:
pdr., Xianzhu, chrishtr
CC:
aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, dglazkov+blink, dmazzoni, dshwang, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, jchaffraix+rendering, je_julie, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (patchset #3 id:40001 of https://codereview.chromium.org/1217943010/) Reason for revert: Suspected for recurring Linux ChromiumOS Tests (dbg)(1) failure in browser_tests ForceMaximizePolicyFalseTestSuite/ForceMaximizePolicyFalseTest.GeneralFirstRun/1 ForceMaximizePolicyFalseTestSuite/ForceMaximizePolicyFalseTest.GeneralFirstRun/0 ForceMaximizeOnFirstRunTestSuite/ForceMaximizeOnFirstRunTest.PRE_TwoRuns/0 ForceMaximizeOnFirstRunTestSuite/ForceMaximizeOnFirstRunTest.TwoRuns/0 Links: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/4232 https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/3951 Errors like: ASSERTION FAILED: canAdvanceTo(state) ../../third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp(220) : void blink::DocumentLifecycle::advanceTo(blink::DocumentLifecycle::State) 1 0x7f163c3843d0 blink::DocumentLifecycle::advanceTo(blink::DocumentLifecycle::State) Original issue's description: > Add a FrameView lifecycle method that just updates layout, style and compositing. > > Hit testing does not need all of the other lifecycle updates (see attached bug > for details). > > BUG=501630 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198284 TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501630 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -116 lines) Patch
M Source/core/css/AffectedByFocusTest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +3 lines, -9 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +19 lines, -35 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DAPITest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/input/EventHandlerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTestHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/page/ContextMenuControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Add a FrameView lifecycle method that just updates layout, style and compositing.
5 years, 5 months ago (2015-07-06 03:43:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216543005/1
5 years, 5 months ago (2015-07-06 03:43:31 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 03:44:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198296

Powered by Google App Engine
This is Rietveld 408576698