Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1216543005: Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/iterators/TextIteratorTest.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 PaintBehavior paintBehavior() const; 220 PaintBehavior paintBehavior() const;
221 void setIsPainting(bool val) { m_isPainting = val; } 221 void setIsPainting(bool val) { m_isPainting = val; }
222 bool isPainting() const; 222 bool isPainting() const;
223 void setLastPaintTime(double val) { m_lastPaintTime = val; } 223 void setLastPaintTime(double val) { m_lastPaintTime = val; }
224 bool hasEverPainted() const { return m_lastPaintTime; } 224 bool hasEverPainted() const { return m_lastPaintTime; }
225 void setNodeToDraw(Node*); 225 void setNodeToDraw(Node*);
226 Node* nodeToDraw() { return m_nodeToDraw.get(); } 226 Node* nodeToDraw() { return m_nodeToDraw.get(); }
227 227
228 Color documentBackgroundColor() const; 228 Color documentBackgroundColor() const;
229 229
230 // Run all needed lifecycle stages. After calling this method, all frames wi ll be in the lifecycle state PaintInvalidationClean. 230 void updateLayoutAndStyleForPainting();
231 void updateAllLifecyclePhases();
232
233 // Computes the style, layout and compositing lifecycle stages if needed. Af ter calling this method, all frames wil lbe in a lifecycle
234 // state >= CompositingClean, and scrolling has been updated.
235 void updateLifecycleToCompositingCleanPlusScrolling();
236 231
237 bool invalidateViewportConstrainedObjects(); 232 bool invalidateViewportConstrainedObjects();
238 233
239 void incrementVisuallyNonEmptyCharacterCount(unsigned); 234 void incrementVisuallyNonEmptyCharacterCount(unsigned);
240 void incrementVisuallyNonEmptyPixelCount(const IntSize&); 235 void incrementVisuallyNonEmptyPixelCount(const IntSize&);
241 void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; } 236 void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; }
242 void enableAutoSizeMode(const IntSize& minSize, const IntSize& maxSize); 237 void enableAutoSizeMode(const IntSize& minSize, const IntSize& maxSize);
243 void disableAutoSizeMode(); 238 void disableAutoSizeMode();
244 239
245 void forceLayoutForPagination(const FloatSize& pageSize, const FloatSize& or iginalPageSize, float maximumShrinkFactor); 240 void forceLayoutForPagination(const FloatSize& pageSize, const FloatSize& or iginalPageSize, float maximumShrinkFactor);
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 private: 596 private:
602 TemporaryChange<bool> m_scope; 597 TemporaryChange<bool> m_scope;
603 }; 598 };
604 599
605 private: 600 private:
606 explicit FrameView(LocalFrame*); 601 explicit FrameView(LocalFrame*);
607 602
608 virtual void setScrollOffset(const IntPoint&, ScrollType) override; 603 virtual void setScrollOffset(const IntPoint&, ScrollType) override;
609 virtual void setScrollOffset(const DoublePoint&, ScrollType) override; 604 virtual void setScrollOffset(const DoublePoint&, ScrollType) override;
610 605
611 void updateAllLifecyclePhasesInternal(); 606 void updateLayoutAndStyleForPaintingInternal();
612 void invalidateTreeIfNeededRecursive(); 607 void invalidateTreeIfNeededRecursive();
613 void scrollContentsIfNeededRecursive(); 608 void scrollContentsIfNeededRecursive();
614 void updateStyleAndLayoutIfNeededRecursive(); 609 void updateLayoutAndStyleIfNeededRecursive();
615 void updatePostLifecycleData();
616 610
617 void reset(); 611 void reset();
618 void init(); 612 void init();
619 613
620 void clearLayoutSubtreeRootsAndMarkContainingBlocks(); 614 void clearLayoutSubtreeRootsAndMarkContainingBlocks();
621 615
622 // Called when our frame rect changes (or the rect/scroll position of an anc estor changes). 616 // Called when our frame rect changes (or the rect/scroll position of an anc estor changes).
623 virtual void frameRectsChanged() override; 617 virtual void frameRectsChanged() override;
624 618
625 friend class LayoutPart; 619 friend class LayoutPart;
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 static const unsigned visualPixelThreshold = 32 * 32; 867 static const unsigned visualPixelThreshold = 32 * 32;
874 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 868 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
875 setIsVisuallyNonEmpty(); 869 setIsVisuallyNonEmpty();
876 } 870 }
877 871
878 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 872 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
879 873
880 } // namespace blink 874 } // namespace blink
881 875
882 #endif // FrameView_h 876 #endif // FrameView_h
OLDNEW
« no previous file with comments | « Source/core/editing/iterators/TextIteratorTest.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698