Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1216523006: Only allow the -webkit-text color keyword in quirks/UA-sheet mode (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Only allow the -webkit-text color keyword in quirks/UA-sheet mode This color keyword is mainly used to implement the 'quirk-inherit' special value for 'color' on <table> in quirks mode [1]. Currently this keyword is treated differently for different properties, but for the most common properties, the "only in quirks mode" rule is applied. It's also marked as "QuirksOrUASheet" in CSSValueKeywords.in. Extend the "only in quirks mode" rule to apply to all <color> properties. The test fast/css/webkit-text-display-none.html is converted to run in quirks mode. It worked previously because setting inline style would use the fast-path color parser which was inconsistent with the non-fast-path color parser in accepting '-webkit-text' in standards mode. [1] https://quirks.spec.whatwg.org/#the-tables-inherit-color-from-body-quirk BUG=505410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -49 lines) Patch
M LayoutTests/fast/css/webkit-text-display-none.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 5 chunks +12 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 5 months ago (2015-07-03 12:54:49 UTC) #2
Timothy Loh
On 2015/07/03 12:54:49, fs wrote: lgtm
5 years, 5 months ago (2015-07-12 23:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216523006/1
5 years, 5 months ago (2015-07-13 07:29:10 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 11:38:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198770

Powered by Google App Engine
This is Rietveld 408576698