Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1216523006: Only allow the -webkit-text color keyword in quirks/UA-sheet mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1216523006: Only allow the -webkit-text color keyword in quirks/UA-sheet mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index 1605e16ccaa9e4e15cfc124d6517e8ba77104726..83d290a3eaf83ff7eb2fbea7ac560ed83a94e22d 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -434,9 +434,9 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSParserFastPaths::parseColor(const String& st

CSSParserString cssString;

cssString.init(string);

CSSValueID valueID = cssValueKeywordID(cssString);

- if (valueID == CSSValueWebkitText || valueID == CSSValueCurrentcolor || valueID == CSSValueGrey

+ if (valueID == CSSValueCurrentcolor || valueID == CSSValueGrey

|| (valueID >= CSSValueAqua && valueID <= CSSValueWindowtext) || valueID == CSSValueMenu

- || (quirksMode && valueID >= CSSValueWebkitFocusRingColor && valueID < CSSValueWebkitText))

+ || (quirksMode && valueID >= CSSValueWebkitFocusRingColor && valueID <= CSSValueWebkitText))

return cssValuePool().createIdentifierValue(valueID);

RGBA32 color;