Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216433002: implement drawAtlas natively on gpu-device (Closed)

Created:
5 years, 5 months ago by reed1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

implement drawAtlas natively on gpu-device BUG=skia: Committed: https://skia.googlesource.com/skia/+/ca10953d9ca38a5486c11cc50ac3fd27d4281e12

Patch Set 1 #

Total comments: 2

Patch Set 2 : use SkRect::toQuad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M samplecode/SampleAtlas.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
reed1
about 20x faster than the default drawPath impl
5 years, 5 months ago (2015-06-25 20:51:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433002/1
5 years, 5 months ago (2015-06-25 20:51:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-25 20:57:13 UTC) #6
reed1
hey, needs some drawAtlas love...
5 years, 5 months ago (2015-06-25 21:17:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433002/1
5 years, 5 months ago (2015-06-25 21:18:08 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-06-25 21:18:09 UTC) #10
bsalomon
otherwise looks good https://codereview.chromium.org/1216433002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1216433002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1642 src/gpu/SkGpuDevice.cpp:1642: static void to_quad(SkPoint quad[], const SkRect& ...
5 years, 5 months ago (2015-06-25 21:31:38 UTC) #11
reed1
https://codereview.chromium.org/1216433002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1216433002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1642 src/gpu/SkGpuDevice.cpp:1642: static void to_quad(SkPoint quad[], const SkRect& r) { On ...
5 years, 5 months ago (2015-06-25 21:47:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216433002/20001
5 years, 5 months ago (2015-06-25 21:48:14 UTC) #14
reed2
lgtm
5 years, 5 months ago (2015-06-25 23:23:20 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-06-25 23:25:30 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ca10953d9ca38a5486c11cc50ac3fd27d4281e12

Powered by Google App Engine
This is Rietveld 408576698