Avoid unspecified behavior in SkiaBitmapDesktopFrame::Create

Avoid unspecified behavior in SkiaBitmapDesktopFrame::Create

Order of argument evaluation is undefined so don't dereference and
Pass() a scoped_ptr in the same argument list.

BUG=

Committed: https://crrev.com/cfd276954a3d536916474ec34b2a19643443a8cf
Cr-Commit-Position: refs/heads/master@{#337669}

[maniscalco, 2015-07-06 16:35:07]

maniscalco@chromium.org changed reviewers:
+ wez@chromium.org

[maniscalco, 2015-07-06 16:35:07]

Noticed this in the code.  Probably not causing an issue now since clang is
(currently) doing left to right evaluation.  PTAL!

[Wez, 2015-07-07 18:46:17]

On 2015/07/06 16:35:07, maniscalco wrote:
> Noticed this in the code.  Probably not causing an issue now since clang is
> (currently) doing left to right evaluation.  PTAL!

Oh, ouch!

(This feels like something a Clang plugin could check for - WDYT?)

LGTM

[maniscalco, 2015-07-07 19:15:40]

On 2015/07/07 18:46:17, Wez wrote:
> On 2015/07/06 16:35:07, maniscalco wrote:
> > Noticed this in the code.  Probably not causing an issue now since clang is
> > (currently) doing left to right evaluation.  PTAL!
> 
> Oh, ouch!
> 
> (This feels like something a Clang plugin could check for - WDYT?)
> 
> LGTM

Agreed.  Looks like we've got a bug to create one already:

https://code.google.com/p/chromium/issues/detail?id=409318

[maniscalco, 2015-07-07 19:23:39]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2015-07-07 19:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216403004/1

[commit-bot: I haz the power, 2015-07-07 19:50:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-07 19:51:34]

Patchset 1 (id:??) landed as
https://crrev.com/cfd276954a3d536916474ec34b2a19643443a8cf
Cr-Commit-Position: refs/heads/master@{#337669}