sky/sdk/lib/rendering/box.dart - Issue 1216303005: Convert image_cache to using Futures rather than callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/rendering/box.dart

Issue 1216303005: Convert image_cache to using Futures rather than callbacks (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix _loadComplete Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/rendering/box.dart

diff --git a/sky/sdk/lib/rendering/box.dart b/sky/sdk/lib/rendering/box.dart

index 515f58c9f43be093f415609a5759963c1bfda79a..c92f822810c79951746fe29761addbde9debeeab 100644

--- a/sky/sdk/lib/rendering/box.dart

+++ b/sky/sdk/lib/rendering/box.dart

@@ -904,7 +904,7 @@ class RenderImage extends RenderBox {

if (value == _src)

return;

_src = value;

- image_cache.load(_src, (result) {

+ image_cache.load(_src).then((result) {

_image = result;

if (requestedSize.width == null || requestedSize.height == null)

markNeedsLayout();

« no previous file with comments | « sky/sdk/lib/painting/box_painter.dart ('k') | no next file » | no next file with comments »