Remove webkit prefix and annotate with experimental tag.

Remove webkit prefix and annotate with experimental tag.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18090

[blois, 2013-02-02 21:36:59]

https://codereview.chromium.org/12163009/diff/4001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/12163009/diff/4001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:895: if key in webkit_member_prefix_renames:
Seems a little fragile to rely on the renamer putting the name in this list
before hitting this code. Would it make sense to just have a method that checks
if the member is webkit-only?

[Emily Fortuna, 2013-02-03 21:17:18]

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:6866: Stream<Event> get
onPointerLockChange => pointerLockChangeEvent.forTarget(this);
The annotations were also added here (and other formerly webkit event names) as
a result of this change. The way to avoid this would be to also check than the
member name isn't in htmleventgenerator.py's _html_event_names, but
htmleventgenerator already imports some members from generator.py, so adding the
_html_event_names import will cause an circular import. I think we really don't
want to add the webkit experimental annotations in this case (because the events
were already renamed indicating they've been polyfilled to not be webkit
only?)... Am I mistaken and we do want the annotations for this case?

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:6570: + 
@SupportedBrowser(SupportedBrowser.CHROME)
FYI: As a side effect of the proposed change, these previously $dom_ methods
that didn't get the "webkit experimental" annotation now have them. It's not
huge, but it does seem to suggest that the $dom_ methods are more welcome to
being used since they're annotated than we'd actually like them to be.

[blois, 2013-02-04 18:16:18]

lgtm

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12163009/diff/10001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:6570: + 
@SupportedBrowser(SupportedBrowser.CHROME)
On 2013/02/03 21:17:18, Emily Fortuna wrote:
> FYI: As a side effect of the proposed change, these previously $dom_ methods
> that didn't get the "webkit experimental" annotation now have them. It's not
> huge, but it does seem to suggest that the $dom_ methods are more welcome to
> being used since they're annotated than we'd actually like them to be.

I think we should convert the $dom_ to _ sometime sooner than later.

If they're annotated as experimental then it's OK, as it gives us the
flexibility to remove/rename later.