Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1216053013: [Extension Toolbar Redesign] Wants to act treatment, redux - left click (Closed)

Created:
5 years, 5 months ago by Devlin
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension Toolbar Redesign] Wants to act treatment, redux - left click The bug fully describes the new behavior for an extension that wants to act with the toolbar redesign turned on. This patch implements the new left-click behavior, so that an otherwise-disabled extension action's clicks forward to the context menu. That is, right clicking on a page action that wouldn't previously be showing opens the menu, instead of running the action. (The user can know when this will happen based on the extension action's enabled/disabled state, which is indicated by greyscaling the action when disabled.) BUG=417441 TBR=sky@chromium.org (media router action) Committed: https://crrev.com/ac27cf3acc998b9e19b2a677e0ffb02378860cca Cr-Commit-Position: refs/heads/master@{#338067}

Patch Set 1 : #

Patch Set 2 : #

Messages

Total messages: 12 (6 generated)
Devlin
5 years, 5 months ago (2015-07-07 23:35:18 UTC) #6
Finnur
LGTM
5 years, 5 months ago (2015-07-08 14:36:40 UTC) #7
Avi (use Gerrit)
Cocoa lgtm
5 years, 5 months ago (2015-07-08 18:39:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216053013/100001
5 years, 5 months ago (2015-07-09 16:59:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 5 months ago (2015-07-09 17:12:42 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 17:13:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac27cf3acc998b9e19b2a677e0ffb02378860cca
Cr-Commit-Position: refs/heads/master@{#338067}

Powered by Google App Engine
This is Rietveld 408576698