chrome/browser/ui/toolbar/toolbar_action_view_controller.h - Issue 1216053013: [Extension Toolbar Redesign] Wants to act treatment, redux - left click

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

Issue 1216053013: [Extension Toolbar Redesign] Wants to act treatment, redux - left click (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

diff --git a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

index 5dba746575b466bcbef40e2689ce2a7a8364e666..98b14ad8ab0f4abee4567d6f3d6d28b2d917ddf2 100644

--- a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

+++ b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

@@ -90,6 +90,10 @@ class ToolbarActionViewController {

// Updates the current state of the action.

virtual void UpdateState() = 0;

+ // Returns true if clicking on an otherwise-disabled action should open the

+ // context menu.

+ virtual bool DisabledClickOpensMenu() const = 0;

// Registers an accelerator. Called when the view is added to the hierarchy.

// Unregistering any commands is the responsibility of the controller.

virtual void RegisterCommand() {