Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215953006: Use sky_shell instead of mojo_shell for testing. (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use sky_shell instead of mojo_shell for testing. This does way more than a single CL should do, sorry. - Fixed a bunch of logging/error reporting during loads. - Made it possible for --package-root to be absolute. - Fixed (hypothetically) parts of iOS build to be clang-plugin-compliant. - Made all tests pass in sky_shell - Removed a bunch of layout_tests including windows support. I'll remove all the mojo test harness stuff in a follow-up patch. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7f465ccb8873ffe7a91e8b792eb398c9f0765b20

Patch Set 1 #

Patch Set 2 : Foo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1009 lines) Patch
M sky/engine/tonic/dart_library_loader.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download
M sky/services/ns_net/network_service_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sky/services/ns_net/network_service_impl.mm View 1 2 chunks +13 lines, -3 lines 0 comments Download
M sky/services/ns_net/url_loader_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/dart/dart_library_provider_files.cc View 1 4 chunks +11 lines, -4 lines 1 comment Download
M sky/shell/linux/main.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download
M sky/shell/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/testing/test_runner.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/trivial.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/resources/display_list.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
D sky/tests/resources/event-sender.dart View 1 1 chunk +0 lines, -109 lines 0 comments Download
A sky/tests/resources/harness.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M sky/tests/resources/unit.dart View 1 1 chunk +1 line, -15 lines 0 comments Download
D sky/tests/services/network.dart View 1 1 chunk +0 lines, -44 lines 0 comments Download
D sky/tests/services/network-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/services/resources/iframe-vmc.js View 1 1 chunk +0 lines, -36 lines 0 comments Download
D sky/tests/services/resources/pass.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/port/android.py View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 3 chunks +2 lines, -20 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/browser_test.py View 1 chunk +0 lines, -97 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/browser_test_driver.py View 1 chunk +0 lines, -91 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/browser_test_driver_unittest.py View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/browser_test_unittest.py View 1 chunk +0 lines, -115 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/driver.py View 2 chunks +7 lines, -11 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/linux.py View 1 chunk +1 line, -3 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/mac.py View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/win.py View 1 chunk +0 lines, -246 lines 0 comments Download
D sky/tools/webkitpy/layout_tests/port/win_unittest.py View 1 chunk +0 lines, -130 lines 0 comments Download
M sky/tools/webkitpy/performance_tests/perftestsrunner_unittest.py View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 5 months ago (2015-07-07 00:30:55 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1215953006/diff/20001/sky/shell/dart/dart_library_provider_files.cc File sky/shell/dart/dart_library_provider_files.cc (right): https://codereview.chromium.org/1215953006/diff/20001/sky/shell/dart/dart_library_provider_files.cc#newcode28 sky/shell/dart/dart_library_provider_files.cc:28: for (;it != components.end(); it++) { s/;it/; it/
5 years, 5 months ago (2015-07-07 00:36:49 UTC) #3
eseidel
5 years, 5 months ago (2015-07-07 00:45:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7f465ccb8873ffe7a91e8b792eb398c9f0765b20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698