Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3061)

Unified Diff: sky/tools/webkitpy/layout_tests/port/android.py

Issue 1215953006: Use sky_shell instead of mojo_shell for testing. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Foo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tools/webkitpy/layout_tests/port/android.py
diff --git a/sky/tools/webkitpy/layout_tests/port/android.py b/sky/tools/webkitpy/layout_tests/port/android.py
index 89000387a351b68a0fc47aca96c63d9d620fca56..64ea1b3416bc8830b3c2b4989369506610d0960f 100644
--- a/sky/tools/webkitpy/layout_tests/port/android.py
+++ b/sky/tools/webkitpy/layout_tests/port/android.py
@@ -426,9 +426,6 @@ class AndroidPort(base.Port):
if not self.get_option('disable_breakpad'):
self._dump_reader = DumpReaderAndroid(host, self._build_path())
- if self.driver_name() != self.CONTENT_SHELL_NAME:
- raise AssertionError('Layout tests on Android only support content_shell as the driver.')
-
self._driver_details = ContentShellDriverDetails()
# Initialize the AndroidDevices class which tracks available devices.
@@ -460,9 +457,6 @@ class AndroidPort(base.Port):
def path_to_md5sum_host(self):
return self._build_path(MD5SUM_HOST_FILE_NAME)
- def additional_drt_flag(self):
- return self._driver_details.additional_command_line_flags(use_breakpad=not self.get_option('disable_breakpad'))
-
def default_timeout_ms(self):
# Android platform has less computing power than desktop platforms.
# Using 10 seconds allows us to pass most slow tests which are not

Powered by Google App Engine
This is Rietveld 408576698