Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: net/dns/mock_host_resolver.cc

Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/mock_host_resolver.cc
diff --git a/net/dns/mock_host_resolver.cc b/net/dns/mock_host_resolver.cc
index 288276be26fa37a6a40e7048ca02bc45692fd11f..a053b9df1aafc78eeae52f090bab3727a87445ae 100644
--- a/net/dns/mock_host_resolver.cc
+++ b/net/dns/mock_host_resolver.cc
@@ -41,13 +41,12 @@ int ParseAddressList(const std::string& host_list,
const std::string& canonical_name,
AddressList* addrlist) {
*addrlist = AddressList();
- std::vector<std::string> addresses;
- base::SplitString(host_list, ',', &addresses);
addrlist->set_canonical_name(canonical_name);
- for (size_t index = 0; index < addresses.size(); ++index) {
+ for (const base::StringPiece& address : base::SplitStringPiece(
+ host_list, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
IPAddressNumber ip_number;
- if (!ParseIPLiteralToNumber(addresses[index], &ip_number)) {
- LOG(WARNING) << "Not a supported IP literal: " << addresses[index];
+ if (!ParseIPLiteralToNumber(address, &ip_number)) {
+ LOG(WARNING) << "Not a supported IP literal: " << address.as_string();
return ERR_UNEXPECTED;
}
addrlist->push_back(IPEndPoint(ip_number, 0));

Powered by Google App Engine
This is Rietveld 408576698