Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1215733005: Do not use title attribute in Files app. (Closed)

Created:
5 years, 5 months ago by mtomasz
Modified:
5 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use title attribute in Files app. We use aria-title instead. This CL renames the cloud import title attributes with aria-title. TEST=Tested with dev tools manually. BUG=None Committed: https://crrev.com/9d291c30bd9380b92b872a7af8825278aa9cee75 Cr-Commit-Position: refs/heads/master@{#337362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/file_manager/file_manager/foreground/js/import_controller.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 5 months ago (2015-07-06 01:06:11 UTC) #2
hirono
On 2015/07/06 01:06:11, mtomasz wrote: > @hirono: PTAL. Thanks. Can we show tooltips with area-labels? ...
5 years, 5 months ago (2015-07-06 03:06:03 UTC) #3
mtomasz
On 2015/07/06 03:06:03, hirono wrote: > On 2015/07/06 01:06:11, mtomasz wrote: > > @hirono: PTAL. ...
5 years, 5 months ago (2015-07-06 03:20:12 UTC) #4
hirono
lgtm!
5 years, 5 months ago (2015-07-06 04:16:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215733005/1
5 years, 5 months ago (2015-07-06 04:20:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 04:23:33 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 04:24:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d291c30bd9380b92b872a7af8825278aa9cee75
Cr-Commit-Position: refs/heads/master@{#337362}

Powered by Google App Engine
This is Rietveld 408576698