Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: ui/file_manager/file_manager/foreground/js/import_controller.js

Issue 1215733005: Do not use title attribute in Files app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/import_controller.js
diff --git a/ui/file_manager/file_manager/foreground/js/import_controller.js b/ui/file_manager/file_manager/foreground/js/import_controller.js
index 95de7829e6488678ba77caef6823fdf749f6ef4a..4db178ed4ba4c089c32d8c6b38498510e2158c4e 100644
--- a/ui/file_manager/file_manager/foreground/js/import_controller.js
+++ b/ui/file_manager/file_manager/foreground/js/import_controller.js
@@ -764,7 +764,7 @@ importer.RuntimeCommandWidget.prototype.update =
console.assert(!!opt_scan, 'Scan not defined, but is required.');
this.setDetailsVisible(false);
- this.mainButton_.setAttribute('title', strf(
+ this.mainButton_.setAttribute('aria-label', strf(
'CLOUD_IMPORT_TOOLTIP_IMPORTING',
opt_scan.getFileEntries().length));
this.statusContent_.innerHTML = strf(
@@ -784,7 +784,7 @@ importer.RuntimeCommandWidget.prototype.update =
case importer.ActivityState.INSUFFICIENT_SPACE:
console.assert(!!opt_scan, 'Scan not defined, but is required.');
- this.mainButton_.setAttribute('title', strf(
+ this.mainButton_.setAttribute('aria-label', strf(
'CLOUD_IMPORT_TOOLTIP_INSUFFICIENT_SPACE'));
this.statusContent_.innerHTML = strf(
'CLOUD_IMPORT_STATUS_INSUFFICIENT_SPACE',
@@ -800,7 +800,7 @@ importer.RuntimeCommandWidget.prototype.update =
break;
case importer.ActivityState.NO_MEDIA:
- this.mainButton_.setAttribute('title', str(
+ this.mainButton_.setAttribute('aria-label', str(
'CLOUD_IMPORT_TOOLTIP_NO_MEDIA'));
this.statusContent_.innerHTML = str(
'CLOUD_IMPORT_STATUS_NO_MEDIA');
@@ -817,7 +817,7 @@ importer.RuntimeCommandWidget.prototype.update =
case importer.ActivityState.READY:
console.assert(!!opt_scan, 'Scan not defined, but is required.');
- this.mainButton_.setAttribute('title', strf(
+ this.mainButton_.setAttribute('aria-label', strf(
'CLOUD_IMPORT_TOOLTIP_READY',
opt_scan.getFileEntries().length));
this.statusContent_.innerHTML = strf(
@@ -836,7 +836,7 @@ importer.RuntimeCommandWidget.prototype.update =
case importer.ActivityState.SCANNING:
console.assert(!!opt_scan, 'Scan not defined, but is required.');
- this.mainButton_.setAttribute('title', str(
+ this.mainButton_.setAttribute('aria-label', str(
'CLOUD_IMPORT_TOOLTIP_SCANNING'));
this.statusContent_.innerHTML = strf(
'CLOUD_IMPORT_STATUS_SCANNING',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698