Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1215713021: Reverted the code for the non-interactive audible tab notification (Closed)

Created:
5 years, 5 months ago by whywhat
Modified:
5 years, 3 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, Tima Vaisburd, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@notification
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated media_codec_player_unittest.cc #

Patch Set 3 : Rebased #

Total comments: 1

Patch Set 4 : Fixed indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -933 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 1 2 3 10 chunks +32 lines, -45 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/media/MediaNotificationService.java View 1 2 3 1 chunk +0 lines, -304 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java View 1 2 3 4 chunks +5 lines, -13 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/android/chrome_main_delegate_android.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D content/browser/android/media_players_observer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/android/media_players_observer.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 6 chunks +3 lines, -12 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 5 chunks +4 lines, -15 lines 0 comments Download
D content/browser/media/audio_state_provider.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/media/audio_state_provider.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/media/audio_stream_monitor.h View 1 2 6 chunks +21 lines, -8 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 1 2 3 chunks +12 lines, -19 lines 0 comments Download
M content/browser/media/audio_stream_monitor_unittest.cc View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 1 2 3 chunks +1 line, -20 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 4 chunks +6 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 7 chunks +5 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/audio_decoder_job.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_codec_player_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_decoder_job.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/android/media_player_android.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/android/media_player_android.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 1 2 4 chunks +4 lines, -18 lines 0 comments Download
M media/base/android/media_player_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 2 7 chunks +2 lines, -30 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 2 7 chunks +0 lines, -156 lines 0 comments Download

Messages

Total messages: 27 (8 generated)
whywhat
Please, take a look. Min and Tima to check if I haven't missed anything John ...
5 years, 5 months ago (2015-07-08 17:25:51 UTC) #2
Ted C
On 2015/07/08 17:25:51, whywhat wrote: > Please, take a look. > > Min and Tima ...
5 years, 5 months ago (2015-07-08 17:28:45 UTC) #3
whywhat
On 2015/07/08 at 17:28:45, tedchoc wrote: > On 2015/07/08 17:25:51, whywhat wrote: > > Please, ...
5 years, 5 months ago (2015-07-08 17:36:59 UTC) #4
qinmin
On 2015/07/08 17:36:59, whywhat wrote: > On 2015/07/08 at 17:28:45, tedchoc wrote: > > On ...
5 years, 5 months ago (2015-07-08 18:46:21 UTC) #5
jam
On 2015/07/08 17:25:51, whywhat wrote: > Please, take a look. > > Min and Tima ...
5 years, 5 months ago (2015-07-09 16:42:54 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215713021/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1215713021/40001
5 years, 3 months ago (2015-08-26 16:12:59 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104698)
5 years, 3 months ago (2015-08-26 16:35:43 UTC) #10
whywhat
PTaL (note this is the revert of the previous four patches you approved before): tedchoc: ...
5 years, 3 months ago (2015-08-26 19:07:59 UTC) #12
whywhat
Ping!
5 years, 3 months ago (2015-08-27 23:31:43 UTC) #13
qinmin
lgtm
5 years, 3 months ago (2015-08-27 23:45:45 UTC) #14
Ted C
lgtm https://codereview.chromium.org/1215713021/diff/40001/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/1215713021/diff/40001/content/browser/media/android/browser_media_player_manager.cc#newcode10 content/browser/media/android/browser_media_player_manager.cc:10: #include "content/browser/media/android/browser_demuxer_android.h" indented too much
5 years, 3 months ago (2015-08-27 23:58:44 UTC) #15
David Trainor- moved to gerrit
lgtm
5 years, 3 months ago (2015-08-28 05:09:06 UTC) #16
whywhat
Fixed indent
5 years, 3 months ago (2015-08-28 11:47:00 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215713021/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1215713021/60001
5 years, 3 months ago (2015-08-28 11:49:09 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 12:54:11 UTC) #21
no sievers
content lgtm
5 years, 3 months ago (2015-08-28 17:50:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215713021/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1215713021/60001
5 years, 3 months ago (2015-08-28 19:05:41 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-28 19:11:21 UTC) #26
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 19:12:23 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cc85bbd51f2dd545ffeadde5b0c739aceca5443b
Cr-Commit-Position: refs/heads/master@{#346205}

Powered by Google App Engine
This is Rietveld 408576698