Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: content/browser/renderer_host/media/video_capture_buffer_pool.cc

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up GN Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_buffer_pool.cc
diff --git a/content/browser/renderer_host/media/video_capture_buffer_pool.cc b/content/browser/renderer_host/media/video_capture_buffer_pool.cc
index f9f83907120d73bf66e931af2d473dd110113b51..0d68b20eee44cdc8b094e68e1aba7b557b69b189 100644
--- a/content/browser/renderer_host/media/video_capture_buffer_pool.cc
+++ b/content/browser/renderer_host/media/video_capture_buffer_pool.cc
@@ -19,7 +19,11 @@ const int VideoCaptureBufferPool::kInvalidId = -1;
class SimpleBufferHandle final : public VideoCaptureBufferPool::BufferHandle {
public:
SimpleBufferHandle(void* data, size_t size, base::SharedMemoryHandle handle)
- : data_(data), size_(size), handle_(handle) {}
+ : data_(data),
+#if defined(OS_POSIX)
+ handle_(handle),
+#endif
+ size_(size) {}
~SimpleBufferHandle() override {}
size_t size() const override { return size_; }
@@ -37,8 +41,10 @@ class SimpleBufferHandle final : public VideoCaptureBufferPool::BufferHandle {
private:
void* const data_;
- const size_t size_;
+#if defined(OS_POSIX)
const base::SharedMemoryHandle handle_;
Nico 2015/07/09 01:58:16 nit: It's strange to have data_ and size_ not next
benwells 2015/07/09 11:43:02 Done.
+#endif
+ const size_t size_;
};
// A holder of a GpuMemoryBuffer-backed buffer, Map()ed on ctor and Unmap()ed on

Powered by Google App Engine
This is Rietveld 408576698