chrome/service/cloud_print/print_system_win.cc - Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up GN Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | content/browser/renderer_host/media/video_capture_buffer_pool.cc » ('j') | content/browser/renderer_host/media/video_capture_buffer_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/print_system_win.cc

diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc

index 36efc242e123b1d288d3c338e668f8b909da8c41..dd1eac7d5ffc3bdf786caa37f3f430a6ef8ec9fb 100644

--- a/chrome/service/cloud_print/print_system_win.cc

+++ b/chrome/service/cloud_print/print_system_win.cc

@@ -35,8 +35,7 @@ namespace {

class PrintSystemWatcherWin : public base::win::ObjectWatcher::Delegate {

public:

PrintSystemWatcherWin()

- : delegate_(NULL),

- did_signal_(false) {

+ : delegate_(NULL) {

}

~PrintSystemWatcherWin() override { Stop(); }

@@ -121,7 +120,6 @@ class PrintSystemWatcherWin : public base::win::ObjectWatcher::Delegate {

// Returned by FindFirstPrinterChangeNotifier.

printing::ScopedPrinterChangeHandle printer_change_;

Delegate* delegate_; // Delegate to notify

- bool did_signal_; // DoneWaiting was called

std::string printer_info_; // For crash reporting.

};