Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215633003: Fix false negatives in system key events recognition (Closed)

Created:
5 years, 5 months ago by joleksy
Modified:
5 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix false negatives in system key events recognition Cmd + <some other modifier> + (b|i) should be treated as a system key event.

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M Source/web/WebInputEventFactoryMac.mm View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/web/tests/WebInputEventFactoryTestMac.mm View 1 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
joleksy
@reviewer: does this look ok to you?
5 years, 5 months ago (2015-06-26 14:09:25 UTC) #1
joleksy
@reviewer: does this look ok to you?
5 years, 5 months ago (2015-07-02 09:09:37 UTC) #3
joleksy
On 2015/07/02 09:09:37, joleksy wrote: > @reviewer: does this look ok to you? Ping?
5 years, 4 months ago (2015-08-21 09:37:40 UTC) #5
joleksy
On 2015/08/21 09:37:40, joleksy wrote: > On 2015/07/02 09:09:37, joleksy wrote: > > @reviewer: does ...
5 years, 2 months ago (2015-09-24 07:57:57 UTC) #7
Mike West
Is it possible to add a test?
5 years, 2 months ago (2015-09-25 08:28:30 UTC) #8
joleksy
On 2015/09/25 08:28:30, Mike West (slow) wrote: > Is it possible to add a test? ...
5 years, 2 months ago (2015-09-25 09:39:56 UTC) #9
Mike West
LGTM, sorry for the delay!
5 years, 2 months ago (2015-09-29 07:13:55 UTC) #10
joleksy
On 2015/09/29 07:13:55, Mike West (slow) wrote: > LGTM, sorry for the delay! No worries:-)
5 years, 2 months ago (2015-09-29 07:17:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1215633003/20001
5 years, 2 months ago (2015-09-29 07:18:00 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 07:18:32 UTC) #15 
Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698