Fix false negatives in system key events recognition

Source/web/tests/WebInputEventFactoryTestMac.mm

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #import <Cocoa/Cocoa.h>
+#include <Carbon/Carbon.h>
 #include <gtest/gtest.h>
 
 #include "core/events/KeyboardEvent.h"
 #include "platform/WindowsKeyboardCodes.h"
 #include "public/web/WebInputEvent.h"
 #include "public/web/mac/WebInputEventFactory.h"
 
 using blink::WebInputEventFactory;
 using blink::WebKeyboardEvent;
 using blink::WebInputEvent;
@@ skipping 141 matching lines @@
         const ModifierKey& key = modifierKeys[i];
         NSEvent* macEvent = BuildFakeKeyEvent(
             key.macKeyCode, 0, key.nonSpecificMask, NSFlagsChanged);
         WebKeyboardEvent webEvent = WebInputEventFactory::keyboardEvent(macEvent);
         EXPECT_EQ(WebInputEvent::RawKeyDown, webEvent.type);
         macEvent = BuildFakeKeyEvent(key.macKeyCode, 0, 0, NSFlagsChanged);
         webEvent = WebInputEventFactory::keyboardEvent(macEvent);
         EXPECT_EQ(WebInputEvent::KeyUp, webEvent.type);
     }
 }
+
+// Test system key events recognition.
+TEST(WebInputEventFactoryTestMac, SystemKeyEvents)
+{
+    // Cmd + B should not be treated as system event.
+    NSEvent* macEvent = BuildFakeKeyEvent(kVK_ANSI_B, 'B', NSCommandKeyMask, NSKeyDown);
+    WebKeyboardEvent webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_FALSE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+
+    // Cmd + I should not be treated as system event.
+    macEvent = BuildFakeKeyEvent(kVK_ANSI_I, 'I', NSCommandKeyMask, NSKeyDown);
+    webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_FALSE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+
+    // Cmd + <some other modifier> + <B|I> should be treated as system event.
+    macEvent = BuildFakeKeyEvent(kVK_ANSI_B, 'B', NSCommandKeyMask | NSShiftKeyMask, NSKeyDown);
+    webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_TRUE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+    macEvent = BuildFakeKeyEvent(kVK_ANSI_I, 'I', NSCommandKeyMask | NSControlKeyMask, NSKeyDown);
+    webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_TRUE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+
+    // Cmd + <any letter other then B and I> should be treated as system event.
+    macEvent = BuildFakeKeyEvent(kVK_ANSI_S, 'S', NSCommandKeyMask, NSKeyDown);
+    webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_TRUE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+
+    // Cmd + <some other modifier> + <any letter other then B and I> should be treated as system event.
+    macEvent = BuildFakeKeyEvent(kVK_ANSI_S, 'S', NSCommandKeyMask | NSShiftKeyMask, NSKeyDown);
+    webEvent = WebInputEventFactory::keyboardEvent(macEvent);
+    EXPECT_TRUE(WebInputEventFactory::isSystemKeyEvent(webEvent));
+}